Return-Path: X-Original-To: apmail-drill-dev-archive@www.apache.org Delivered-To: apmail-drill-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D146117626 for ; Tue, 9 Jun 2015 22:11:03 +0000 (UTC) Received: (qmail 9515 invoked by uid 500); 9 Jun 2015 22:11:03 -0000 Delivered-To: apmail-drill-dev-archive@drill.apache.org Received: (qmail 9462 invoked by uid 500); 9 Jun 2015 22:11:03 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 9451 invoked by uid 500); 9 Jun 2015 22:11:03 -0000 Delivered-To: apmail-incubator-drill-dev@incubator.apache.org Received: (qmail 9445 invoked by uid 99); 9 Jun 2015 22:11:03 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Jun 2015 22:11:03 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0A3791DF939; Tue, 9 Jun 2015 22:11:00 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2134812066491502192==" MIME-Version: 1.0 Subject: Re: Review Request 35051: DRILL-2089: Part 6--Rename DrillPreparedStatement to ...Impl. [various] From: "Daniel Barclay" To: "Mehant Baid" , "Parth Chandra" Cc: "drill" , "Daniel Barclay" Date: Tue, 09 Jun 2015 22:11:00 -0000 Message-ID: <20150609221100.27736.33171@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Daniel Barclay" X-ReviewGroup: drill-git X-ReviewRequest-URL: https://reviews.apache.org/r/35051/ X-Sender: "Daniel Barclay" References: <20150609210214.27736.45839@reviews.apache.org> In-Reply-To: <20150609210214.27736.45839@reviews.apache.org> Reply-To: "Daniel Barclay" X-ReviewRequest-Repository: drill-git --===============2134812066491502192== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On June 9, 2015, 9:02 p.m., Parth Chandra wrote: > > Same comment as previous review about removing empty files. Same reply re checking/re-making/re-uploading patch and base patch. - Daniel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35051/#review87296 ----------------------------------------------------------- On June 9, 2015, 10:10 p.m., Daniel Barclay wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35051/ > ----------------------------------------------------------- > > (Updated June 9, 2015, 10:10 p.m.) > > > Review request for drill, Mehant Baid and Parth Chandra. > > > Bugs: DRILL-2089 > https://issues.apache.org/jira/browse/DRILL-2089 > > > Repository: drill-git > > > Description > ------- > > Renamed DrillPreparedStatement to DrillPreparedStatementImpl (because name "DrillPreparedStatement" is reserved for Drill subinterface of PreparedStatement). > > > Diffs > ----- > > exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillConnectionImpl.java PRE-CREATION > exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillJdbc41Factory.java PRE-CREATION > exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillPreparedStatement.java PRE-CREATION > exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillPreparedStatementImpl.java PRE-CREATION > > Diff: https://reviews.apache.org/r/35051/diff/ > > > Testing > ------- > > Ran existing tests. (With parts 1 through 7 together.) > > > Thanks, > > Daniel Barclay > > --===============2134812066491502192==--