Return-Path: X-Original-To: apmail-drill-dev-archive@www.apache.org Delivered-To: apmail-drill-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 200D71765E for ; Wed, 3 Jun 2015 00:05:09 +0000 (UTC) Received: (qmail 70454 invoked by uid 500); 2 Jun 2015 23:38:29 -0000 Delivered-To: apmail-drill-dev-archive@drill.apache.org Received: (qmail 70421 invoked by uid 500); 2 Jun 2015 23:38:29 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 70410 invoked by uid 500); 2 Jun 2015 23:38:28 -0000 Delivered-To: apmail-incubator-drill-dev@incubator.apache.org Received: (qmail 70404 invoked by uid 99); 2 Jun 2015 23:38:28 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Jun 2015 23:38:28 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A86401DE686; Tue, 2 Jun 2015 23:38:28 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1203128009160467719==" MIME-Version: 1.0 Subject: Re: Review Request 34839: DRILL-3155: Part 2 From: "Hanifi Gunes" To: "Hanifi Gunes" Cc: "Mehant Baid" , "drill" Date: Tue, 02 Jun 2015 23:38:28 -0000 Message-ID: <20150602233828.1498.21341@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Hanifi Gunes" X-ReviewGroup: drill-git X-ReviewRequest-URL: https://reviews.apache.org/r/34839/ X-Sender: "Hanifi Gunes" References: <20150602214948.1498.93128@reviews.apache.org> In-Reply-To: <20150602214948.1498.93128@reviews.apache.org> Reply-To: "Hanifi Gunes" X-ReviewRequest-Repository: drill-git --===============1203128009160467719== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34839/#review86325 ----------------------------------------------------------- Ship it! Ship It! - Hanifi Gunes On June 2, 2015, 9:49 p.m., Mehant Baid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34839/ > ----------------------------------------------------------- > > (Updated June 2, 2015, 9:49 p.m.) > > > Review request for drill and Hanifi Gunes. > > > Repository: drill-git > > > Description > ------- > > While allocating memory for composite vectors if one of the allocation fails we need to release all the allocated memory upto that point. > > > Diffs > ----- > > exec/java-exec/src/main/codegen/templates/NullableValueVectors.java 90ec6be > exec/java-exec/src/main/codegen/templates/RepeatedValueVectors.java 7b2b78d > exec/java-exec/src/main/codegen/templates/VariableLengthVectors.java b3389e2 > exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/AbstractMapVector.java 3c01939 > exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/BaseRepeatedValueVector.java PRE-CREATION > exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedMapVector.java a97847b > > Diff: https://reviews.apache.org/r/34839/diff/ > > > Testing > ------- > > > Thanks, > > Mehant Baid > > --===============1203128009160467719==--