Return-Path: X-Original-To: apmail-drill-dev-archive@www.apache.org Delivered-To: apmail-drill-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4E89718D80 for ; Mon, 1 Jun 2015 17:54:47 +0000 (UTC) Received: (qmail 10797 invoked by uid 500); 1 Jun 2015 17:54:47 -0000 Delivered-To: apmail-drill-dev-archive@drill.apache.org Received: (qmail 10743 invoked by uid 500); 1 Jun 2015 17:54:47 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 10732 invoked by uid 500); 1 Jun 2015 17:54:46 -0000 Delivered-To: apmail-incubator-drill-dev@incubator.apache.org Received: (qmail 10725 invoked by uid 99); 1 Jun 2015 17:54:46 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Jun 2015 17:54:46 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id C3CAB1DDDE6; Mon, 1 Jun 2015 17:54:44 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3592150906757594413==" MIME-Version: 1.0 Subject: Re: Review Request 34829: DRILL-3190: Invalid FragmentState transition from CANCELLATION_REQUESTED in QueryManager From: "Sudheesh Katkam" To: "Jacques Nadeau" , "Chris Westin" , "abdelhakim deneche" Cc: "Sudheesh Katkam" , "drill" Date: Mon, 01 Jun 2015 17:54:44 -0000 Message-ID: <20150601175444.3246.71886@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Sudheesh Katkam" X-ReviewGroup: drill-git X-ReviewRequest-URL: https://reviews.apache.org/r/34829/ X-Sender: "Sudheesh Katkam" References: <20150529204437.8664.70751@reviews.apache.org> In-Reply-To: <20150529204437.8664.70751@reviews.apache.org> Reply-To: "Sudheesh Katkam" X-ReviewRequest-Repository: drill-git --===============3592150906757594413== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34829/ ----------------------------------------------------------- (Updated June 1, 2015, 5:54 p.m.) Review request for drill, abdelhakim deneche, Chris Westin, and Jacques Nadeau. Changes ------- Addressed review comments + move fragment state transition logic to QueryManager Bugs: DRILL-3190 https://issues.apache.org/jira/browse/DRILL-3190 Repository: drill-git Description (updated) ------- DRILL-3190: Check for transitions from CANCELLATION_REQUESTED state + Moved state transition checks to QueryManager Diffs (updated) ----- exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/FragmentData.java ceb77f0 exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/QueryManager.java 71b77c6 Diff: https://reviews.apache.org/r/34829/diff/ Testing (updated) ------- Successful unit and regression tests. Thanks, Sudheesh Katkam --===============3592150906757594413==--