drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jinfeng Ni" <...@maprtech.com>
Subject Re: Review Request 36019: Patch for DRILL-3418
Date Mon, 29 Jun 2015 21:38:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36019/#review89805
-----------------------------------------------------------



exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/RewriteAsBinaryOperators.java
(line 110)
<https://reviews.apache.org/r/36019/#comment142600>

    You may consider overriding visitLocalRef() in both visitors. The default one in RexVisitorImpl
just return null, which seems not right.  On the other hand, I'm also not clear when/where
LocalRef would be created in Rex expression. It probably would not cause big issue for partiton
pruning if not override. For consisentency, it might be better to do so.
    
      public R visitLocalRef(RexLocalRef localRef) {
        return null;
      }


- Jinfeng Ni


On June 29, 2015, 1:42 p.m., Steven Phillips wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36019/
> -----------------------------------------------------------
> 
> (Updated June 29, 2015, 1:42 p.m.)
> 
> 
> Review request for drill.
> 
> 
> Bugs: DRILL-3418
>     https://issues.apache.org/jira/browse/DRILL-3418
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> DRILL-3414: Make sure to walk entire expression tree when rewriting filter expression
for pruning
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/RewriteAsBinaryOperators.java
44b9a3a8fbd22744f98b9b4b64c9b7aceae7587a 
>   exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/RewriteCombineBinaryOperators.java
247ad8f0fa883f6c765d94edac58d1b5e2193ddb 
>   exec/java-exec/src/test/java/org/apache/drill/TestCTASPartitionFilter.java 48d7cebb26d2bf08baff39d6232e4829bd98d648

> 
> Diff: https://reviews.apache.org/r/36019/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Steven Phillips
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message