drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jinfeng Ni" <...@maprtech.com>
Subject Re: Review Request 35894: DRILL-3183: Query that uses window functions returns NPE
Date Thu, 25 Jun 2015 22:40:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35894/#review89442
-----------------------------------------------------------

Ship it!


Ship It!

- Jinfeng Ni


On June 25, 2015, 3:05 p.m., Sean Hsuan-Yi Chu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35894/
> -----------------------------------------------------------
> 
> (Updated June 25, 2015, 3:05 p.m.)
> 
> 
> Review request for drill, Aman Sinha and Jinfeng Ni.
> 
> 
> Bugs: DRILL-3183
>     https://issues.apache.org/jira/browse/DRILL-3183
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> Enable compound identifier conversion in window defintion
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/CompoundIdentifierConverter.java
fbc5f9b 
>   exec/java-exec/src/test/java/org/apache/drill/exec/TestWindowFunctions.java 5a7a07e

> 
> Diff: https://reviews.apache.org/r/35894/diff/
> 
> 
> Testing
> -------
> 
> All the requested tests passed
> 
> 
> Thanks,
> 
> Sean Hsuan-Yi Chu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message