drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "abdelhakim deneche" <adene...@gmail.com>
Subject Review Request 35881: DRILL-3354: TestBuilder can check if the number of result batches equals some expected value
Date Thu, 25 Jun 2015 16:53:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35881/
-----------------------------------------------------------

Review request for drill and Jason Altekruse.


Bugs: DRILL-3354
    https://issues.apache.org/jira/browse/DRILL-3354


Repository: drill-git


Description
-------

Unit tests can specifiy an expectedNumBatches when using the TestBuilder, these tests will
fail if they receive a different number of result batches.
I also updated TestWindowFrame to use this feature


Diffs
-----

  exec/java-exec/src/test/java/org/apache/drill/DrillTestWrapper.java d4e7ed6 
  exec/java-exec/src/test/java/org/apache/drill/TestBuilder.java 666ecda 
  exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/window/TestWindowFrame.java
1d6c517 

Diff: https://reviews.apache.org/r/35881/diff/


Testing
-------

unit tests are passing


Thanks,

abdelhakim deneche


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message