drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "abdelhakim deneche" <adene...@gmail.com>
Subject Re: Review Request 35609: DRILL-3243: Need a better error message - Use of alias in window function definition
Date Thu, 25 Jun 2015 15:52:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35609/
-----------------------------------------------------------

(Updated June 25, 2015, 3:52 p.m.)


Review request for drill and Hanifi Gunes.


Changes
-------

rebased on top of master


Bugs: DRILL-3243
    https://issues.apache.org/jira/browse/DRILL-3243


Repository: drill-git


Description
-------

changed RepeatedVarCharOutput to display the column name as part of the exception's message
changed CompliantTestRecordReader to throw a DATA_READ user exception
added new unit test to TestNewTextReader


Diffs (updated)
-----

  common/src/main/java/org/apache/drill/common/exceptions/UserException.java 13c17bd 
  common/src/main/java/org/apache/drill/common/exceptions/UserRemoteException.java 1b3fa42

  exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/compliant/CompliantTextRecordReader.java
254e0d8 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/compliant/RepeatedVarCharOutput.java
40276f4 
  exec/java-exec/src/test/java/org/apache/drill/exec/store/text/TestNewTextReader.java 76674f9


Diff: https://reviews.apache.org/r/35609/diff/


Testing
-------

all unit tests are passing along with functional and tpch100


Thanks,

abdelhakim deneche


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message