drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hanifi Gunes" <hanifigu...@gmail.com>
Subject Re: Review Request 35573: DRILL-3304: improve org.apache.drill.exec.expr.TypeHelper error messages when UnsupportedOprationException is thrown
Date Tue, 23 Jun 2015 19:00:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35573/#review89028
-----------------------------------------------------------

Ship it!


Ship It!

- Hanifi Gunes


On June 18, 2015, 3:56 p.m., abdelhakim deneche wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35573/
> -----------------------------------------------------------
> 
> (Updated June 18, 2015, 3:56 p.m.)
> 
> 
> Review request for drill and Hanifi Gunes.
> 
> 
> Bugs: DRILL-3304
>     https://issues.apache.org/jira/browse/DRILL-3304
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> Made some changes to TypeHelper template to display the failed "operation" and minor-type
+ data-mode when an UnsupportedOperationException is thrown
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/drill/common/exceptions/ErrorHelper.java 5dd9b67 
>   exec/java-exec/src/main/codegen/templates/TypeHelper.java ad818bd 
> 
> Diff: https://reviews.apache.org/r/35573/diff/
> 
> 
> Testing
> -------
> 
> all unit tests are passing along with functional/tpch100
> 
> 
> Thanks,
> 
> abdelhakim deneche
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message