drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kamesh B" <kamesh.had...@gmail.com>
Subject Re: Review Request 35720: DRILL-3177: Various Mongo plugin enhancements
Date Mon, 22 Jun 2015 06:45:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35720/#review88739
-----------------------------------------------------------


There are two minor comments.

1. The MongoClient (and ServerAddress) constructors no longer throw UnknownHostException.
So, I think, we can remove handling or throwing this.
2. While creating shardClient in MongoGroupScan#init (line# 223), using all hosts rather than
taking only first host.


I addressed them in my later version of this patch (https://reviews.apache.org/r/34625/diff/2#1).

- Kamesh B


On June 22, 2015, 12:52 a.m., Jacques Nadeau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35720/
> -----------------------------------------------------------
> 
> (Updated June 22, 2015, 12:52 a.m.)
> 
> 
> Review request for drill, Kamesh B and Steven Phillips.
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> - Upgrading Mongo Java Driver to 3.0.1 (by Kamesh)
> - Fix issues with initial Mongo 3 update patch
> - Update mongo connection management so we don't generate infinite MongoClients.
> - Move from static class to management inside Storage Plugin.
> - Increase limit on number of connections.
> - move mongo cursor initialization to batch reading, so a query won't block indefinitely
on this code
> - Update mongo driver version to 3.0.2
> 
> 
> Diffs
> -----
> 
>   contrib/storage-mongo/pom.xml 8168861 
>   contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/MongoCnxnManager.java
35cc265 
>   contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/MongoGroupScan.java
e33d2ae 
>   contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/MongoRecordReader.java
182f5a4 
>   contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/MongoScanBatchCreator.java
3a8a496 
>   contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/MongoStoragePlugin.java
38bc91d 
>   contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/MongoUtils.java
b43a22f 
>   contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/schema/MongoSchemaFactory.java
fccffb5 
> 
> Diff: https://reviews.apache.org/r/35720/diff/
> 
> 
> Testing
> -------
> 
> in progress
> 
> 
> Thanks,
> 
> Jacques Nadeau
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message