drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jinfeng Ni" <...@maprtech.com>
Subject Re: Review Request 35629: DRILL-3316: Ensure different SQLHandlers should go through the same planning logics for the same SELECT statement.
Date Sat, 20 Jun 2015 00:49:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35629/
-----------------------------------------------------------

(Updated June 19, 2015, 5:49 p.m.)


Review request for drill and Venki Korukanti.


Changes
-------

Revise code based on review comments.


Repository: drill-git


Description
-------

n this JIRA, we are going to refactor part of SqlHandler code in query planning component,
such that the same SELECT statement will go through the same planning logic, whether it use
DefaultSqlHandler, or CreateTableHandler, or CreateViewHandler, or ExplainHandler.


Diffs (updated)
-----

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/CreateTableHandler.java
2866b8c 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DefaultSqlHandler.java
5e685c8 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ExplainHandler.java
5924c7e 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/SqlHandlerUtil.java
3edcdb2 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ViewHandler.java
0a3393e 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlCreateView.java
57cfde9 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlDropView.java 473dbcb

  exec/jdbc/src/test/java/org/apache/drill/jdbc/DatabaseMetaDataGetColumnsTest.java 5e59e8c

  exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestInformationSchemaColumns.java 3f820f5


Diff: https://reviews.apache.org/r/35629/diff/


Testing
-------

Unit test.
Pre-commit test. (Found cases where CTAS have different behaviour from regular SELECT statement).


Thanks,

Jinfeng Ni


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message