drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aman Sinha" <asi...@maprtech.com>
Subject Re: Review Request 35584: DRILL-3298: fix wrong result for window function query when no partition-by is present
Date Thu, 18 Jun 2015 19:07:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35584/
-----------------------------------------------------------

(Updated June 18, 2015, 7:07 p.m.)


Review request for drill and Jinfeng Ni.


Changes
-------

New patch after incorporating review comments and adding unit test.


Bugs: DRILL-3298
    https://issues.apache.org/jira/browse/DRILL-3298


Repository: drill-git


Description
-------

The JIRA DRILL-3298 has relevant discussion on this.  The fix involves creating a single stream
as input to the Window by inserting a SingleMergeExchange if only the ORDER-BY clause is present
in a Window.  This ensures that the Sort below the Window is done in parallel followed by
a Merge.


Diffs (updated)
-----

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/WindowPrule.java f7728c8

  exec/java-exec/src/test/java/org/apache/drill/exec/TestWindowFunctions.java 2ec2481 

Diff: https://reviews.apache.org/r/35584/diff/


Testing
-------

Manual testing of the query in DRILL-3298.  Ran unit tests.  Functional tests are in progress.


Thanks,

Aman Sinha


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message