drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "abdelhakim deneche" <adene...@gmail.com>
Subject Re: Review Request 35417: DRILL-3285: Part 5--Split old hacky next() into separate methods.
Date Wed, 17 Jun 2015 23:57:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35417/#review88309
-----------------------------------------------------------


LGTM +1 (non-binding)

I do have some small suggestions

- abdelhakim deneche


On June 17, 2015, 5:06 p.m., Daniel Barclay wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35417/
> -----------------------------------------------------------
> 
> (Updated June 17, 2015, 5:06 p.m.)
> 
> 
> Review request for drill and abdelhakim deneche.
> 
> 
> Bugs: DRILL-3285
>     https://issues.apache.org/jira/browse/DRILL-3285
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> Split the original public next() method (which was hacked to handle an extra,
> initial call to read the schema batch) into:
> - new loadInitialSchema() (for handling the call for the schema)
> - modified next() (for handling normal calls from ResultSet.next())
> - new private nextRowInternally() (for common code)
> 
> Pulled invariant afterFirstBatch up out of bogus-batch loop.
> 
> 
> Diffs
> -----
> 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillCursor.java PRE-CREATION 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java cb6bd1d

> 
> Diff: https://reviews.apache.org/r/35417/diff/
> 
> 
> Testing
> -------
> 
> Ran tests (all parts together); no new errors.
> 
> 
> Thanks,
> 
> Daniel Barclay
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message