drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Barclay" <dbarc...@maprtech.com>
Subject Re: Review Request 35050: DRILL-2089: Part 5--Reduce excess visibility (remove (now-)unneeded "public").
Date Tue, 16 Jun 2015 01:50:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35050/
-----------------------------------------------------------

(Updated June 16, 2015, 1:50 a.m.)


Review request for drill, Mehant Baid and Parth Chandra.


Changes
-------

Re-uploading patches, trying to fix/work around Review Board empty-files problem.


Bugs: DRILL-2089
    https://issues.apache.org/jira/browse/DRILL-2089


Repository: drill-git


Description
-------

Purged interim "public" from earlier partial DRILL-2089 fixes.
Purged other "public" qualifiers no longer needed.


Diffs (updated)
-----

  exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/AvaticaDrillSqlAccessor.java PRE-CREATION

  exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillAccessorList.java PRE-CREATION 
  exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillConnectionImpl.java PRE-CREATION

  exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillCursor.java PRE-CREATION 
  exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillDatabaseMetaData.java PRE-CREATION

  exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillFactory.java PRE-CREATION 
  exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillHandler.java PRE-CREATION 
  exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillJdbc40Factory.java PRE-CREATION

  exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillJdbc41Factory.java PRE-CREATION

  exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillPrepareResult.java PRE-CREATION

  exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillRemoteStatement.java PRE-CREATION

  exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java cb6bd1d 
  exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java 6610f52 
  exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementRegistry.java PRE-CREATION

  exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DriverImpl.java PRE-CREATION 
  exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/GlobalServiceSetReference.java PRE-CREATION

  exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/MetaImpl.java PRE-CREATION 
  exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/TypeConvertingSqlAccessor.java e095c42


Diff: https://reviews.apache.org/r/35050/diff/


Testing
-------

Ran existing tests.  (With parts 1 through 7 together.)


Thanks,

Daniel Barclay


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message