drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "abdelhakim deneche" <adene...@gmail.com>
Subject Review Request 35477: DRILL-3268: queries with empty OVER() clause return empty result set
Date Mon, 15 Jun 2015 22:27:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35477/
-----------------------------------------------------------

Review request for drill, Mehant Baid and Steven Phillips.


Repository: drill-git


Description
-------

fixed WindowFrameRecordBatch.buildSchema() to properly handle non empty batches
extended TestWindowFrame to test over clause without partition by


Diffs
-----

  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/window/WindowFrameRecordBatch.java
da189eb 
  exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/window/GenerateTestData.java
623c1e2 
  exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/window/TestWindowFrame.java
aefe77d 
  exec/java-exec/src/test/resources/window/b1.p1.oby.tsv PRE-CREATION 
  exec/java-exec/src/test/resources/window/b1.p1.pby.oby.tsv PRE-CREATION 
  exec/java-exec/src/test/resources/window/b1.p1.pby.tsv PRE-CREATION 
  exec/java-exec/src/test/resources/window/b1.p1.subs.tsv 8368d4a 
  exec/java-exec/src/test/resources/window/b1.p1/0.data.json cd34641 
  exec/java-exec/src/test/resources/window/b1.p2.oby.tsv PRE-CREATION 
  exec/java-exec/src/test/resources/window/b1.p2.pby.oby.tsv PRE-CREATION 
  exec/java-exec/src/test/resources/window/b1.p2.pby.tsv PRE-CREATION 
  exec/java-exec/src/test/resources/window/b1.p2.subs.tsv edc4b6a 
  exec/java-exec/src/test/resources/window/b1.p2.tsv 2bd0010 
  exec/java-exec/src/test/resources/window/b1.p2/0.data.json b70cf91 
  exec/java-exec/src/test/resources/window/b2.p2.oby.tsv PRE-CREATION 
  exec/java-exec/src/test/resources/window/b2.p2.pby.oby.tsv PRE-CREATION 
  exec/java-exec/src/test/resources/window/b2.p2.pby.tsv PRE-CREATION 
  exec/java-exec/src/test/resources/window/b2.p2.subs.tsv 153efaf 
  exec/java-exec/src/test/resources/window/b2.p2.tsv 9e62ba7 
  exec/java-exec/src/test/resources/window/b2.p2/0.data.json 3e7efda 
  exec/java-exec/src/test/resources/window/b2.p2/1.data.json acdd419 
  exec/java-exec/src/test/resources/window/b2.p4.oby.tsv PRE-CREATION 
  exec/java-exec/src/test/resources/window/b2.p4.pby.oby.tsv PRE-CREATION 
  exec/java-exec/src/test/resources/window/b2.p4.pby.tsv PRE-CREATION 
  exec/java-exec/src/test/resources/window/b2.p4.subs.tsv 62def92 
  exec/java-exec/src/test/resources/window/b2.p4.tsv a9302c6 
  exec/java-exec/src/test/resources/window/b2.p4/0.data.json 02da7b8 
  exec/java-exec/src/test/resources/window/b2.p4/1.data.json 3ed76af 
  exec/java-exec/src/test/resources/window/b3.p2.oby.tsv PRE-CREATION 
  exec/java-exec/src/test/resources/window/b3.p2.pby.oby.tsv PRE-CREATION 
  exec/java-exec/src/test/resources/window/b3.p2.pby.tsv PRE-CREATION 
  exec/java-exec/src/test/resources/window/b3.p2.subs.tsv 3e735aa 
  exec/java-exec/src/test/resources/window/b3.p2.tsv ef32c2e 
  exec/java-exec/src/test/resources/window/b3.p2/0.data.json 39e285f 
  exec/java-exec/src/test/resources/window/b3.p2/1.data.json 1d92e1a 
  exec/java-exec/src/test/resources/window/b3.p2/2.data.json e0f5f3c 
  exec/java-exec/src/test/resources/window/b4.p4.oby.tsv PRE-CREATION 
  exec/java-exec/src/test/resources/window/b4.p4.pby.oby.tsv PRE-CREATION 
  exec/java-exec/src/test/resources/window/b4.p4.pby.tsv PRE-CREATION 
  exec/java-exec/src/test/resources/window/b4.p4.subs.tsv c13597b 
  exec/java-exec/src/test/resources/window/b4.p4.tsv 29c57ae 
  exec/java-exec/src/test/resources/window/b4.p4/0.data.json c40697c 
  exec/java-exec/src/test/resources/window/b4.p4/1.data.json 472c9b5 
  exec/java-exec/src/test/resources/window/b4.p4/2.data.json 292200c 
  exec/java-exec/src/test/resources/window/b4.p4/3.data.json cd9008c 
  exec/java-exec/src/test/resources/window/q1.sql 053b701 
  exec/java-exec/src/test/resources/window/q2.sql 0e661a7 

Diff: https://reviews.apache.org/r/35477/diff/


Testing
-------

all unit tests are passing...


Thanks,

abdelhakim deneche


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message