drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Altekruse" <altekruseja...@gmail.com>
Subject Review Request 35475: DRILL-3263: read tinyint and smallint columns from Hive as integer
Date Mon, 15 Jun 2015 21:58:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35475/
-----------------------------------------------------------

Review request for drill, Mehant Baid and Venki Korukanti.


Bugs: DRILL-3263
    https://issues.apache.org/jira/browse/DRILL-3263


Repository: drill-git


Description
-------

Smallint and tinyint hve been disabled in much of Drill as they were only partly implemented.
Drill-2470 has been opened to track the completion of the tinyint and smallint types. Untill
this task is complete this change will enable a wider range of queries to work with standard
sql functions and Drill's implicit cast system. The change is pretty small, it just changes
the type exposed from Hive tables with columns of smallint or tinyint to be a regular integer.


Diffs
-----

  contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveFieldConverter.java
658dd79 
  contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveRecordReader.java
3c8b9ba 
  contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/schema/DrillHiveTable.java
0da28e0 
  contrib/storage-hive/core/src/test/java/org/apache/drill/exec/fn/hive/HiveTestUDFImpls.java
31e4715 
  contrib/storage-hive/core/src/test/java/org/apache/drill/exec/fn/hive/TestSampleHiveUDFs.java
86a78e5 
  contrib/storage-hive/core/src/test/java/org/apache/drill/exec/hive/TestHiveStorage.java
27ba9fe 

Diff: https://reviews.apache.org/r/35475/diff/


Testing
-------

Unit tests passing, cluster tests are pending


Thanks,

Jason Altekruse


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message