drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Parth Chandra" <pchan...@maprtech.com>
Subject Re: Review Request 35236: DRILL-3198: Fix: DatabaseMetaData.getTypeInfo(...), etc., return null.
Date Thu, 11 Jun 2015 23:39:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35236/#review87651
-----------------------------------------------------------

Ship it!


Ship It!

- Parth Chandra


On June 9, 2015, 6:38 a.m., Daniel Barclay wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35236/
> -----------------------------------------------------------
> 
> (Updated June 9, 2015, 6:38 a.m.)
> 
> 
> Review request for drill, Mehant Baid and Parth Chandra.
> 
> 
> Bugs: DRILL-3198
>     https://issues.apache.org/jira/browse/DRILL-3198
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> Fixed DatabaseMetaData.getTypeInfo(...) and similar methods enough to not return
> null.  (Each method now returns a ResultSet representing a result set with zero
> rows, though not with JDBC-specified columns.)
>     
> - Changed utility method getEmptyResult().
> - Added basic test methods.
> - Added interface DrillDatabaseMetaData (for place to document current
>   Drill-specific behavior).
> - Added Javadoc for current behavior.
> 
> 
> Diffs
> -----
> 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillDatabaseMetaData.java 4b2d694 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillResultSet.java 2e3d49f 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillDatabaseMetaDataImpl.java PRE-CREATION

>   exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/MetaImpl.java PRE-CREATION 
>   exec/jdbc/src/test/java/org/apache/drill/jdbc/DatabaseMetaDataTest.java 886f974 
> 
> Diff: https://reviews.apache.org/r/35236/diff/
> 
> 
> Testing
> -------
> 
> Ran new specific tests.
> 
> Ran existing tests; no new failures.
> 
> 
> Thanks,
> 
> Daniel Barclay
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message