drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Hsuan-Yi Chu" <hsua...@usc.edu>
Subject Re: Review Request 35163: DRILL-1169: Add support for UNION (distinct type)
Date Thu, 11 Jun 2015 17:56:15 GMT


> On June 11, 2015, 12:24 a.m., Aman Sinha wrote:
> > exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillUnionRel.java,
line 60
> > <https://reviews.apache.org/r/35163/diff/2/?file=981609#file981609line60>
> >
> >     I think you should modify the DrillUnionRule to handle the distinct vs. non-distinct
case rather than changing the cost function here.

Correct the code according to the comment;


- Sean Hsuan-Yi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35163/#review87496
-----------------------------------------------------------


On June 9, 2015, 5:37 p.m., Sean Hsuan-Yi Chu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35163/
> -----------------------------------------------------------
> 
> (Updated June 9, 2015, 5:37 p.m.)
> 
> 
> Review request for drill, Aman Sinha and Jinfeng Ni.
> 
> 
> Bugs: DRILL-1169
>     https://issues.apache.org/jira/browse/DRILL-1169
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> Use Union-All followed by Aggregate to implement Union-Distinct
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillRuleSets.java
655ad92 
>   exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillUnionRel.java
566c558 
>   exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java
f1ec851 
>   exec/java-exec/src/test/java/org/apache/drill/TestDisabledFunctionality.java adbf653

>   exec/java-exec/src/test/java/org/apache/drill/TestUnionDistinct.java PRE-CREATION 
>   exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q1.tsv PRE-CREATION

>   exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q10.tsv PRE-CREATION

>   exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q11.tsv PRE-CREATION

>   exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q12.tsv PRE-CREATION

>   exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q13.tsv PRE-CREATION

>   exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q14.tsv PRE-CREATION

>   exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q15.tsv PRE-CREATION

>   exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q16.tsv PRE-CREATION

>   exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q17.tsv PRE-CREATION

>   exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q18_1.tsv
PRE-CREATION 
>   exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q18_2.tsv
PRE-CREATION 
>   exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q18_3.tsv
PRE-CREATION 
>   exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q2.tsv PRE-CREATION

>   exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q3.tsv PRE-CREATION

>   exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q4.tsv PRE-CREATION

>   exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q5.tsv PRE-CREATION

>   exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q6.tsv PRE-CREATION

>   exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q6_1.tsv PRE-CREATION

>   exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q7.tsv PRE-CREATION

>   exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q8.tsv PRE-CREATION

>   exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q9.tsv PRE-CREATION

>   exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testAggregationOnUnionDistinctOperator_1.tsv
PRE-CREATION 
>   exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testAggregationOnUnionDistinctOperator_2.tsv
PRE-CREATION 
>   exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testProjectDownOverUnionDistinctImplicitCasting.tsv
PRE-CREATION 
>   exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testProjectFiltertPushDownOverUnionDistinct.tsv
PRE-CREATION 
>   exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testProjectPushDownOverUnionDistinctWithProject.tsv
PRE-CREATION 
>   exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testProjectPushDownOverUnionDistinctWithoutProject.tsv
PRE-CREATION 
>   exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testProjectPushDownProjectColumnReorderingAndAlias.tsv
PRE-CREATION 
>   exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testProjectWithExpressionPushDownOverUnionDistinct.tsv
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/35163/diff/
> 
> 
> Testing
> -------
> 
> all the required tests
> 
> 
> Thanks,
> 
> Sean Hsuan-Yi Chu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message