drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Barclay" <dbarc...@maprtech.com>
Subject Re: Review Request 35051: DRILL-2089: Part 6--Rename DrillPreparedStatement to ...Impl. [various]
Date Tue, 09 Jun 2015 22:10:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35051/
-----------------------------------------------------------

(Updated June 9, 2015, 10:10 p.m.)


Review request for drill, Mehant Baid and Parth Chandra.


Changes
-------

Re-uploaded base patch to fix changed files that showed up as empty.


Bugs: DRILL-2089
    https://issues.apache.org/jira/browse/DRILL-2089


Repository: drill-git


Description
-------

Renamed DrillPreparedStatement to DrillPreparedStatementImpl (because name "DrillPreparedStatement"
is reserved for Drill subinterface of PreparedStatement).


Diffs (updated)
-----

  exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillConnectionImpl.java PRE-CREATION

  exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillJdbc41Factory.java PRE-CREATION

  exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillPreparedStatement.java PRE-CREATION

  exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillPreparedStatementImpl.java PRE-CREATION


Diff: https://reviews.apache.org/r/35051/diff/


Testing
-------

Ran existing tests.  (With parts 1 through 7 together.)


Thanks,

Daniel Barclay


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message