drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Barclay" <dbarc...@maprtech.com>
Subject Re: Review Request 35144: DRILL-3216: Part 2--Fix existing(+) INFORMATION_SCHEMA.COLUMNS columns.
Date Sun, 07 Jun 2015 00:40:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35144/
-----------------------------------------------------------

(Updated June 7, 2015, 12:40 a.m.)


Review request for drill, Mehant Baid and Parth Chandra.


Bugs: DRILL-3216
    https://issues.apache.org/jira/browse/DRILL-3216


Repository: drill-git


Description (updated)
-------

Added unit test.  [TempInformationSchemaColumnsTest]
    
Hygiene:
- Created, applied getIntOrNull(...) to simplify return-value checks.
    
Fixed/added INFORMATION_SCHEMA.COLUMNS columns:
- Changed -1 to NULL.
- Moved column NUMERIC_PRECISION to correct position.
- Fixed column ORDINAL_POSITION from 0-based to 1-based.
- Moved CHAR length to column CHARACTER_MAXIMUM_LENGTH.
- Moved BINARY and VARBINARY length to columnCHARACTER_MAXIMUM_LENGTH.
- Added precision and scale values for integer types and floating-point types.
- Added column COLUMN_DEFAULT.
- Added column CHARACTER_OCTET_LENGTH.
- Added column DATETIME_PRECISION.
- Added column INTERVAL_TYPE.
- Added column INTERVAL_PRECISION.
- Fixed column DATA_TYPE to correct form of type names:
  - "INTERVAL_..." -> "INTERVAL"
  - short (e.g., "CHAR") to specified (e.g., "CHARACTER")
    
Applied COLUMNS to JDBC DatabaseMetaData.getColumns() implementation:
- Changed some getColumns() result values:
  - type names (DATA_TYPE changes)
  - precision radix for some cases
- Adapted existing uses of COLUMNS data.
- Applied new COLUMNS data (e.g., interval precision).
- Updated getColumns() test (re changed result values).
- Augmented getColumns() test (e.g., more intervals).

Updated other tests using INFORMATION_SCHEMA.COLUMNS:
- -1 -> NULL
- integer types have precision and scale values
- "CHAR" -> "CHARACTER", etc.
[TestInfoSchema, TestInfoSchemaOnHiveStorage, TestInformationSchemaColumns,
TestViewSupport]


Diffs (updated)
-----

  contrib/storage-hive/core/src/test/java/org/apache/drill/exec/hive/TestInfoSchemaOnHiveStorage.java
d8ab5c0 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/ischema/InfoSchemaConstants.java
1c29235 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/ischema/InfoSchemaTable.java 0f8b8a0

  exec/java-exec/src/main/java/org/apache/drill/exec/store/ischema/Records.java 39b4f3e 
  exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestInfoSchema.java 9a35be4 
  exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestViewSupport.java e3156d0 
  exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/MetaImpl.java PRE-CREATION 
  exec/jdbc/src/test/java/org/apache/drill/jdbc/DatabaseMetaDataGetColumnsTest.java a4fccf6

  exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestInformationSchemaColumns.java PRE-CREATION


Diff: https://reviews.apache.org/r/35144/diff/


Testing (updated)
-------

Ran new specific tests.

Ran existing test.  No unexpected errors.


Thanks,

Daniel Barclay


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message