drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aman Sinha" <asi...@maprtech.com>
Subject Re: Review Request 34954: DRILL-3196: Disable multiple partition by clauses in the same sql query
Date Sat, 06 Jun 2015 00:00:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34954/#review86868
-----------------------------------------------------------



exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java
<https://reviews.apache.org/r/34954/#comment139001>

    There's some confusion about what exactly multiple-partition means.  Is it multiple columns
in a single partition-by or different columns in 2 or more partition-by clauses.  Also, the
error should represent something about different order-by criteria not supported.



exec/java-exec/src/test/java/org/apache/drill/exec/TestWindowFunctions.java
<https://reviews.apache.org/r/34954/#comment138996>

    It would be good to add 1 test where there are 2 window functions with the same partition-by
but different order-by column.  I believe this should also throw unsupported exception.


- Aman Sinha


On June 2, 2015, 9:35 p.m., Sean Hsuan-Yi Chu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34954/
> -----------------------------------------------------------
> 
> (Updated June 2, 2015, 9:35 p.m.)
> 
> 
> Review request for drill and Aman Sinha.
> 
> 
> Bugs: DRILL-3196
>     https://issues.apache.org/jira/browse/DRILL-3196
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> After validation, detech if there is no than one partition
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java
f1ec851 
>   exec/java-exec/src/test/java/org/apache/drill/exec/TestWindowFunctions.java PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/34954/diff/
> 
> 
> Testing
> -------
> 
> All the requested tests
> 
> 
> Thanks,
> 
> Sean Hsuan-Yi Chu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message