drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Barclay" <dbarc...@maprtech.com>
Subject Review Request 35143: DRILL-3216: Part 1--Pre-core code hygiene
Date Fri, 05 Jun 2015 20:49:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35143/
-----------------------------------------------------------

Review request for drill, Mehant Baid and Parth Chandra.


Bugs: DRILL-3216
    https://issues.apache.org/jira/browse/DRILL-3216


Repository: drill-git


Description
-------

Many-instance changes:  [DatabaseMetaDataGetColumnsTest]
- Renamed "...opt..." columns and methods to match "...mdrOpt" variables.
- Renamed "...req..." columns and methods to match "...mdrReq" variables.
- Renamed "testRow..." variables to "mdrUnk".
- Edited "nullability code" -> "nullability code:".
    
Renamed "type" -> "relDataType"; "sqlType" -> "sqlTypeName".
Changed "dfs_test.tmp" -> VIEW_SCHEMA.
Re-aligned query SQL.
Added 2 "final".
Edited 3253 (test plugin) TODOs.
Purged several comments.
Wrapped some lines.


Diffs
-----

  exec/java-exec/src/main/java/org/apache/drill/exec/store/ischema/Records.java 39b4f3e 
  exec/jdbc/src/test/java/org/apache/drill/jdbc/DatabaseMetaDataGetColumnsTest.java a4fccf6


Diff: https://reviews.apache.org/r/35143/diff/


Testing
-------

[TBD]


Thanks,

Daniel Barclay


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message