Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
Received-SPF: softfail (nike.apache.org: transitioning domain of
 dbarclay@maprtech.com does not designate 54.76.25.247 as permitted sender)
Message-ID: <5547D428.3080706@maprtech.com>
Date: Mon, 04 May 2015 13:18:48 -0700
From: Daniel Barclay <dbarclay@maprtech.com>
Organization: MapR Technologies
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:35.0) Gecko/20100101 Firefox/35.0 SeaMonkey/2.32.1
MIME-Version: 1.0
To: dev@drill.apache.org
Subject: Re: RecordBatchLoader.load(...) SchemaChangeException
References: <5547BC8E.6050702@maprtech.com>
In-Reply-To: <5547BC8E.6050702@maprtech.com>
Content-Type: multipart/alternative;
 boundary="------------070105030500070103010103"

--------------070105030500070103010103
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

To clarify:

load(...) returns a boolean value to indicate whether there was a schema change.

Initially, I thought that throwing SchemaChangeException was an old way of indicating a schema change, and so thought that the throws declaration and various catches were obsolete.

However, reportedly SchemaChangeException is or was for reporting /problems/ in making schema changes, not for reporting normal schema changes.

Therefore, the code is not /necessarily /as obsolete as I initially thought.

With that clarification, I re-submit the question:

I wrote:
> In RecordBatchLoader, the load(...) method is declared to throw
> SchemaChangeException, but it never actually throws SchemaChangeException.
>
> It supposed to be declared to throw SchemaChangeException?  (E.g., are we
> reserving the "right" for load(...) to throw that, and declaring "throws
> SchemaChangeException" to help make sure callers already handle it in case
> load(...) later changes to actually throw it sometimes?)
>
> Or is that "throws" a remnant that should be removed sometime?
>
>
> Daniel


-- 
Daniel Barclay
MapR Technologies


--------------070105030500070103010103--