Return-Path: X-Original-To: apmail-drill-dev-archive@www.apache.org Delivered-To: apmail-drill-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4BE4B187AD for ; Fri, 29 May 2015 21:49:09 +0000 (UTC) Received: (qmail 93886 invoked by uid 500); 29 May 2015 21:49:09 -0000 Delivered-To: apmail-drill-dev-archive@drill.apache.org Received: (qmail 93831 invoked by uid 500); 29 May 2015 21:49:09 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 93820 invoked by uid 500); 29 May 2015 21:49:08 -0000 Delivered-To: apmail-incubator-drill-dev@incubator.apache.org Received: (qmail 93813 invoked by uid 99); 29 May 2015 21:49:08 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 29 May 2015 21:49:08 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 685201DDCE1; Fri, 29 May 2015 21:49:07 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6991268825058392043==" MIME-Version: 1.0 Subject: Re: Review Request 34829: DRILL-3190: Invalid FragmentState transition from CANCELLATION_REQUESTED in QueryManager From: "abdelhakim deneche" To: "Jacques Nadeau" , "Chris Westin" , "abdelhakim deneche" Cc: "Sudheesh Katkam" , "drill" Date: Fri, 29 May 2015 21:49:07 -0000 Message-ID: <20150529214907.8660.64190@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "abdelhakim deneche" X-ReviewGroup: drill-git X-ReviewRequest-URL: https://reviews.apache.org/r/34829/ X-Sender: "abdelhakim deneche" References: <20150529204437.8664.70751@reviews.apache.org> In-Reply-To: <20150529204437.8664.70751@reviews.apache.org> Reply-To: "abdelhakim deneche" X-ReviewRequest-Repository: drill-git --===============6991268825058392043== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34829/#review85822 ----------------------------------------------------------- exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/FragmentData.java Foreman state management is already split between the Foreman and the QueryManager. This will make the FragmentData handle part of that logic too! Shouldn't we move this to the QueryManager instead ? at least we would have one less class to check involved - abdelhakim deneche On May 29, 2015, 8:44 p.m., Sudheesh Katkam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34829/ > ----------------------------------------------------------- > > (Updated May 29, 2015, 8:44 p.m.) > > > Review request for drill, abdelhakim deneche, Chris Westin, and Jacques Nadeau. > > > Bugs: DRILL-3190 > https://issues.apache.org/jira/browse/DRILL-3190 > > > Repository: drill-git > > > Description > ------- > > DRILL-3190: Check for transition from CANCELLATION_REQUESTED to non-terminal state in FragmentData > > > Diffs > ----- > > exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/FragmentData.java ceb77f0 > > Diff: https://reviews.apache.org/r/34829/diff/ > > > Testing > ------- > > Running unit and regresssion tests. > > > Thanks, > > Sudheesh Katkam > > --===============6991268825058392043==--