Return-Path: X-Original-To: apmail-drill-dev-archive@www.apache.org Delivered-To: apmail-drill-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 46C40188BD for ; Fri, 22 May 2015 22:25:30 +0000 (UTC) Received: (qmail 9372 invoked by uid 500); 22 May 2015 22:25:30 -0000 Delivered-To: apmail-drill-dev-archive@drill.apache.org Received: (qmail 9320 invoked by uid 500); 22 May 2015 22:25:30 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 9309 invoked by uid 500); 22 May 2015 22:25:29 -0000 Delivered-To: apmail-incubator-drill-dev@incubator.apache.org Received: (qmail 9304 invoked by uid 99); 22 May 2015 22:25:29 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 May 2015 22:25:29 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 1DB071DD786; Fri, 22 May 2015 22:25:29 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4408211591043358279==" MIME-Version: 1.0 Subject: Re: Review Request 34497: DRILL-3108: Replace templated returns with covariant return overrides From: "Parth Chandra" To: "Parth Chandra" Cc: "Hanifi Gunes" , "drill" Date: Fri, 22 May 2015 22:25:29 -0000 Message-ID: <20150522222529.17474.19562@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Parth Chandra" X-ReviewGroup: drill-git X-ReviewRequest-URL: https://reviews.apache.org/r/34497/ X-Sender: "Parth Chandra" References: <20150520210451.17212.20407@reviews.apache.org> In-Reply-To: <20150520210451.17212.20407@reviews.apache.org> Reply-To: "Parth Chandra" X-ReviewRequest-Repository: drill-git --===============4408211591043358279== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34497/#review85008 ----------------------------------------------------------- Ship it! Ship It! - Parth Chandra On May 20, 2015, 9:04 p.m., Hanifi Gunes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34497/ > ----------------------------------------------------------- > > (Updated May 20, 2015, 9:04 p.m.) > > > Review request for drill and Parth Chandra. > > > Repository: drill-git > > > Description > ------- > > DRILL-3108: Replace templated returns with covariant return overrides > - Removed template declarations from VV > - Deleted unused SerializableVector > > > Diffs > ----- > > exec/java-exec/src/main/java/org/apache/drill/exec/vector/BaseDataValueVector.java 6d356f2c24947d435dcbe2ce2bc776727f6c8e26 > exec/java-exec/src/main/java/org/apache/drill/exec/vector/BaseRepeatedValueVector.java bcf0793751443ffed5879d36e09dc97ac4f2591f > exec/java-exec/src/main/java/org/apache/drill/exec/vector/BaseValueVector.java 67c489daf0a172d4fe0f8df1abb07a0454091299 > exec/java-exec/src/main/java/org/apache/drill/exec/vector/RepeatedValueVector.java d5a82816a3ca4fb1a6ab99244188f9997a7d3a2b > exec/java-exec/src/main/java/org/apache/drill/exec/vector/SerializableVector.java 62c8a18eac9cc5e964ce38fa0441bf84f36f7e93 > exec/java-exec/src/main/java/org/apache/drill/exec/vector/ValueVector.java ab9992e6fa68c7986ad35c44a8ebb50d656e5915 > exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedListVector.java b5de8b1e2081e13c36fe563002dad00341367b6e > > Diff: https://reviews.apache.org/r/34497/diff/ > > > Testing > ------- > > > Thanks, > > Hanifi Gunes > > --===============4408211591043358279==--