Return-Path: X-Original-To: apmail-drill-dev-archive@www.apache.org Delivered-To: apmail-drill-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1061018276 for ; Thu, 14 May 2015 22:46:08 +0000 (UTC) Received: (qmail 13397 invoked by uid 500); 14 May 2015 22:46:07 -0000 Delivered-To: apmail-drill-dev-archive@drill.apache.org Received: (qmail 13350 invoked by uid 500); 14 May 2015 22:46:07 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 13312 invoked by uid 500); 14 May 2015 22:46:07 -0000 Delivered-To: apmail-incubator-drill-dev@incubator.apache.org Received: (qmail 13305 invoked by uid 99); 14 May 2015 22:46:07 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 May 2015 22:46:07 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 3EFBE1DD48C; Thu, 14 May 2015 22:46:07 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2130450205443682060==" MIME-Version: 1.0 Subject: Re: Review Request 34184: DRILL-3065: Memory Leak at ExternalSortBatch From: "abdelhakim deneche" To: "Steven Phillips" , "abdelhakim deneche" , "Jinfeng Ni" Cc: "Sean Hsuan-Yi Chu" , "drill" Date: Thu, 14 May 2015 22:46:07 -0000 Message-ID: <20150514224607.1461.21173@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "abdelhakim deneche" X-ReviewGroup: drill-git X-ReviewRequest-URL: https://reviews.apache.org/r/34184/ X-Sender: "abdelhakim deneche" References: <20150514224003.1460.66190@reviews.apache.org> In-Reply-To: <20150514224003.1460.66190@reviews.apache.org> Reply-To: "abdelhakim deneche" X-ReviewRequest-Repository: drill-git --===============2130450205443682060== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On May 14, 2015, 10:40 p.m., abdelhakim deneche wrote: > > exec/java-exec/src/test/java/org/apache/drill/exec/server/TestDrillbitResilience.java, line 803 > > > > > > Should this test be part of TestDrillbitResilience ? > > Sean Hsuan-Yi Chu wrote: > It is just a utility function helping write the test cases. my bad, actually thought it was a unit test. - abdelhakim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34184/#review83858 ----------------------------------------------------------- On May 14, 2015, 9:59 p.m., Sean Hsuan-Yi Chu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34184/ > ----------------------------------------------------------- > > (Updated May 14, 2015, 9:59 p.m.) > > > Review request for drill, abdelhakim deneche, Jinfeng Ni, and Steven Phillips. > > > Bugs: DRILL-3065 > https://issues.apache.org/jira/browse/DRILL-3065 > > > Repository: drill-git > > > Description > ------- > > Clean the SelectionVector4 in mSort after failure happens > > > Diffs > ----- > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/ExternalSortBatch.java 529a6ca > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/MSortTemplate.java 9acae9e > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/MSorter.java d97ffc0 > exec/java-exec/src/test/java/org/apache/drill/exec/server/TestDrillbitResilience.java f95fbe1 > > Diff: https://reviews.apache.org/r/34184/diff/ > > > Testing > ------- > > Unit test passed; Others are running > > > Thanks, > > Sean Hsuan-Yi Chu > > --===============2130450205443682060==--