Return-Path: X-Original-To: apmail-drill-dev-archive@www.apache.org Delivered-To: apmail-drill-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0869B17C97 for ; Wed, 13 May 2015 22:05:08 +0000 (UTC) Received: (qmail 58755 invoked by uid 500); 13 May 2015 22:05:07 -0000 Delivered-To: apmail-drill-dev-archive@drill.apache.org Received: (qmail 58702 invoked by uid 500); 13 May 2015 22:05:07 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 58640 invoked by uid 500); 13 May 2015 22:05:07 -0000 Delivered-To: apmail-incubator-drill-dev@incubator.apache.org Received: (qmail 58633 invoked by uid 99); 13 May 2015 22:05:07 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 May 2015 22:05:07 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 1923A1DD39D; Wed, 13 May 2015 22:05:07 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3445418689347871328==" MIME-Version: 1.0 Subject: Re: Review Request 34173: DRILL-3053: add unchecked exception injection site in ChildAllocator From: "abdelhakim deneche" To: "Jacques Nadeau" , "Chris Westin" Cc: "Sudheesh Katkam" , "abdelhakim deneche" , "drill" Date: Wed, 13 May 2015 22:05:07 -0000 Message-ID: <20150513220507.1461.79950@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "abdelhakim deneche" X-ReviewGroup: drill-git X-ReviewRequest-URL: https://reviews.apache.org/r/34173/ X-Sender: "abdelhakim deneche" References: <20150513213607.1461.43913@reviews.apache.org> In-Reply-To: <20150513213607.1461.43913@reviews.apache.org> Reply-To: "abdelhakim deneche" X-ReviewRequest-Repository: drill-git --===============3445418689347871328== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34173/ ----------------------------------------------------------- (Updated May 13, 2015, 10:05 p.m.) Review request for drill, Chris Westin and Jacques Nadeau. Changes ------- small code fixes Bugs: DRILL-3053 https://issues.apache.org/jira/browse/DRILL-3053 Repository: drill-git Description ------- added an unchecked injection site in ChildAllocator.buffer(int, int). It's only enabled when assertions are enabled. You can throw any unchecked or Error exception, but if you throw a NullPointerException the buffer() method will just return "null" without throwing any exception to simulate a "normal" allocation failure Diffs (updated) ----- common/src/main/java/org/apache/drill/common/exceptions/DrillRuntimeException.java abc7065 common/src/main/java/org/apache/drill/common/exceptions/UserException.java a67cb3f exec/java-exec/src/main/java/org/apache/drill/exec/memory/TopLevelAllocator.java 9670c7e exec/java-exec/src/main/java/org/apache/drill/exec/testing/ExecutionControlsInjector.java 387d300 exec/java-exec/src/test/java/org/apache/drill/TestAllocationException.java PRE-CREATION Diff: https://reviews.apache.org/r/34173/diff/ Testing (updated) ------- testing... Thanks, abdelhakim deneche --===============3445418689347871328==--