Return-Path: X-Original-To: apmail-drill-dev-archive@www.apache.org Delivered-To: apmail-drill-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8823317796 for ; Tue, 12 May 2015 00:32:50 +0000 (UTC) Received: (qmail 55682 invoked by uid 500); 12 May 2015 00:32:50 -0000 Delivered-To: apmail-drill-dev-archive@drill.apache.org Received: (qmail 55620 invoked by uid 500); 12 May 2015 00:32:50 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 55609 invoked by uid 500); 12 May 2015 00:32:50 -0000 Delivered-To: apmail-incubator-drill-dev@incubator.apache.org Received: (qmail 55602 invoked by uid 99); 12 May 2015 00:32:50 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 May 2015 00:32:50 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id AD5D11D7BC4; Tue, 12 May 2015 00:32:50 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7949374362646327457==" MIME-Version: 1.0 Subject: Re: Review Request 34008: DRILL:2977: In WorkManager, startFragmentPendingRemote() and addFragmentRunner() need to be permuted From: "Sudheesh Katkam" To: "Venki Korukanti" , "Jacques Nadeau" , "abdelhakim deneche" Cc: "Sudheesh Katkam" , "drill" Date: Tue, 12 May 2015 00:32:50 -0000 Message-ID: <20150512003250.12559.78491@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Sudheesh Katkam" X-ReviewGroup: drill-git X-ReviewRequest-URL: https://reviews.apache.org/r/34008/ X-Sender: "Sudheesh Katkam" References: <20150511231641.12558.79649@reviews.apache.org> In-Reply-To: <20150511231641.12558.79649@reviews.apache.org> Reply-To: "Sudheesh Katkam" X-ReviewRequest-Repository: drill-git --===============7949374362646327457== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34008/ ----------------------------------------------------------- (Updated May 12, 2015, 12:32 a.m.) Review request for drill, abdelhakim deneche, Jacques Nadeau, and Venki Korukanti. Changes ------- Addressed review comments Repository: drill-git Description ------- [DRILL-2977](https://issues.apache.org/jira/browse/DRILL-2977), [DRILL-2978](https://issues.apache.org/jira/browse/DRILL-2978): Swap fragment execution methods and cancellation changes Execution: In WorkManager, + swap implementations of startFragmentPendingRemote() and addFragmentRunner() + warn if there are running fragments in close() Cancellation: + for fragments waiting on data, delegate cancellations to WorkEventBus (in Foreman and ControlMessageHandler) + documentation Diffs (updated) ----- exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/WorkEventBus.java d90096a exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java 1d3a0b0 exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/ControlMessageHandler.java d12e6d5 exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/QueryManager.java 090a377 exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/RootFragmentManager.java 67ef9b8 Diff: https://reviews.apache.org/r/34008/diff/ Testing ------- Passes all unit tests and regression tests. Thanks, Sudheesh Katkam --===============7949374362646327457==--