Return-Path: X-Original-To: apmail-drill-dev-archive@www.apache.org Delivered-To: apmail-drill-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6606A17427 for ; Mon, 11 May 2015 23:27:07 +0000 (UTC) Received: (qmail 2501 invoked by uid 500); 11 May 2015 23:27:07 -0000 Delivered-To: apmail-drill-dev-archive@drill.apache.org Received: (qmail 2443 invoked by uid 500); 11 May 2015 23:27:07 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 2430 invoked by uid 500); 11 May 2015 23:27:06 -0000 Delivered-To: apmail-incubator-drill-dev@incubator.apache.org Received: (qmail 2422 invoked by uid 99); 11 May 2015 23:27:06 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 May 2015 23:27:06 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 85B8F1D7BC4; Mon, 11 May 2015 23:27:07 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4562907403837287511==" MIME-Version: 1.0 Subject: Re: Review Request 34063: DRILL-2776: add extensive tests for empty population coverage From: "abdelhakim deneche" To: "Venki Korukanti" , "Mehant Baid" , "abdelhakim deneche" Cc: "Hanifi Gunes" , "drill" Date: Mon, 11 May 2015 23:27:07 -0000 Message-ID: <20150511232707.12558.29854@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "abdelhakim deneche" X-ReviewGroup: drill-git X-ReviewRequest-URL: https://reviews.apache.org/r/34063/ X-Sender: "abdelhakim deneche" References: <20150511231827.12558.9078@reviews.apache.org> In-Reply-To: <20150511231827.12558.9078@reviews.apache.org> Reply-To: "abdelhakim deneche" X-ReviewRequest-Repository: drill-git --===============4562907403837287511== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34063/#review83314 ----------------------------------------------------------- LGTM, +1 (non binding) - abdelhakim deneche On May 11, 2015, 11:18 p.m., Hanifi Gunes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34063/ > ----------------------------------------------------------- > > (Updated May 11, 2015, 11:18 p.m.) > > > Review request for drill, abdelhakim deneche, Mehant Baid, and Venki Korukanti. > > > Repository: drill-git > > > Description > ------- > > DRILL-2776: add extensive tests for empty population coverage > > > Diffs > ----- > > exec/java-exec/src/test/java/org/apache/drill/exec/vector/complex/TestEmptyPopulation.java PRE-CREATION > exec/java-exec/src/test/java/org/apache/drill/exec/vector/complex/TestEmptyPopulator.java 23cc316aac7e7d64fea2a2549a42d0a9c4d401bb > exec/java-exec/src/test/resources/vector/complex/map-empty-between.json PRE-CREATION > exec/java-exec/src/test/resources/vector/complex/map-empty-first.json PRE-CREATION > exec/java-exec/src/test/resources/vector/complex/map-empty-last.json PRE-CREATION > exec/java-exec/src/test/resources/vector/complex/repeated-list-empty-between.json PRE-CREATION > exec/java-exec/src/test/resources/vector/complex/repeated-list-empty-first.json PRE-CREATION > exec/java-exec/src/test/resources/vector/complex/repeated-list-empty-last.json PRE-CREATION > exec/java-exec/src/test/resources/vector/complex/repeated-map-empty-between.json PRE-CREATION > exec/java-exec/src/test/resources/vector/complex/repeated-map-empty-first.json PRE-CREATION > exec/java-exec/src/test/resources/vector/complex/repeated-map-empty-last.json PRE-CREATION > exec/java-exec/src/test/resources/vector/complex/repeated-scalar-empty-between.json PRE-CREATION > exec/java-exec/src/test/resources/vector/complex/repeated-scalar-empty-first.json PRE-CREATION > exec/java-exec/src/test/resources/vector/complex/repeated-scalar-empty-last.json PRE-CREATION > > Diff: https://reviews.apache.org/r/34063/diff/ > > > Testing > ------- > > TestEmptyPopulation > > > Thanks, > > Hanifi Gunes > > --===============4562907403837287511==--