Return-Path: X-Original-To: apmail-drill-dev-archive@www.apache.org Delivered-To: apmail-drill-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CDB62179A2 for ; Mon, 11 May 2015 20:36:53 +0000 (UTC) Received: (qmail 5465 invoked by uid 500); 11 May 2015 20:36:53 -0000 Delivered-To: apmail-drill-dev-archive@drill.apache.org Received: (qmail 5413 invoked by uid 500); 11 May 2015 20:36:53 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 5397 invoked by uid 500); 11 May 2015 20:36:53 -0000 Delivered-To: apmail-incubator-drill-dev@incubator.apache.org Received: (qmail 5391 invoked by uid 99); 11 May 2015 20:36:53 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 May 2015 20:36:53 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id C581A1CBF50; Mon, 11 May 2015 20:36:53 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1623125401803613105==" MIME-Version: 1.0 Subject: Re: Review Request 33949: DRILL-2476 Handle IterOutcome.STOP in buildSchema() From: "Sudheesh Katkam" To: "abdelhakim deneche" , "Steven Phillips" Cc: "Sudheesh Katkam" , "drill" Date: Mon, 11 May 2015 20:36:53 -0000 Message-ID: <20150511203653.12559.21291@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Sudheesh Katkam" X-ReviewGroup: drill-git X-ReviewRequest-URL: https://reviews.apache.org/r/33949/ X-Sender: "Sudheesh Katkam" References: <20150507175531.1562.38494@reviews.apache.org> In-Reply-To: <20150507175531.1562.38494@reviews.apache.org> Reply-To: "Sudheesh Katkam" X-ReviewRequest-Repository: drill-git --===============1623125401803613105== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33949/ ----------------------------------------------------------- (Updated May 11, 2015, 8:36 p.m.) Review request for drill, abdelhakim deneche and Steven Phillips. Changes ------- + rebased on master + addressed Hakim's comments Repository: drill-git Description ------- DRILL-2476: Added BatchState.STOP in buildSchema() so AbstractRecordBatch returns IterOutcome.STOP Diffs (updated) ----- exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/TopN/TopNBatch.java c3e70f5 exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/WriterRecordBatch.java 28a99d9 exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java 56ce0ee exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/MergeJoinBatch.java 0430f1b exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/NestedLoopJoinBatch.java 4c86f5c exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/mergereceiver/MergingRecordBatch.java 5d990f0 exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/ExternalSortBatch.java 3159811 Diff: https://reviews.apache.org/r/33949/diff/ Testing ------- Thanks, Sudheesh Katkam --===============1623125401803613105==--