Return-Path: X-Original-To: apmail-drill-dev-archive@www.apache.org Delivered-To: apmail-drill-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0B93F17DFD for ; Mon, 11 May 2015 18:06:36 +0000 (UTC) Received: (qmail 50876 invoked by uid 500); 11 May 2015 18:06:35 -0000 Delivered-To: apmail-drill-dev-archive@drill.apache.org Received: (qmail 50823 invoked by uid 500); 11 May 2015 18:06:35 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 50811 invoked by uid 500); 11 May 2015 18:06:35 -0000 Delivered-To: apmail-incubator-drill-dev@incubator.apache.org Received: (qmail 50805 invoked by uid 99); 11 May 2015 18:06:35 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 May 2015 18:06:35 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0C9B81CBF50; Mon, 11 May 2015 18:06:36 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3724067078710731927==" MIME-Version: 1.0 Subject: Review Request 34028: DRILL-3020: Copy cause exception's message to thrown SQLException's message. From: "Daniel Barclay" To: "Mehant Baid" , "Parth Chandra" Cc: "drill" , "Daniel Barclay" Date: Mon, 11 May 2015 18:06:36 -0000 Message-ID: <20150511180636.12559.5276@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Daniel Barclay" X-ReviewGroup: drill-git X-ReviewRequest-URL: https://reviews.apache.org/r/34028/ X-Sender: "Daniel Barclay" Reply-To: "Daniel Barclay" X-ReviewRequest-Repository: drill-git --===============3724067078710731927== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34028/ ----------------------------------------------------------- Review request for drill, Mehant Baid and Parth Chandra. Bugs: DRILL-3020 https://issues.apache.org/jira/browse/DRILL-3020 Repository: drill-git Description ------- Changed SQLException construction to set SQLException's message to the cause exception's toString(). Also: - Narrowed one SQLException to SQLNonTransientConnectionException (not other two, since unclear whether transient, non-transient, or varied). - Clarified/simplified exception messages. - Fixed message typo. Diffs ----- exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnectionImpl.java 30279e6 exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillCursor.java 30c85eb Diff: https://reviews.apache.org/r/34028/diff/ Testing ------- Manually tested in SQLLine. Ran regular tests; no new failures. Thanks, Daniel Barclay --===============3724067078710731927==--