Return-Path: X-Original-To: apmail-drill-dev-archive@www.apache.org Delivered-To: apmail-drill-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3AA77180E1 for ; Mon, 11 May 2015 07:48:16 +0000 (UTC) Received: (qmail 15407 invoked by uid 500); 11 May 2015 07:14:27 -0000 Delivered-To: apmail-drill-dev-archive@drill.apache.org Received: (qmail 15379 invoked by uid 500); 11 May 2015 07:14:27 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 15232 invoked by uid 500); 11 May 2015 07:14:03 -0000 Delivered-To: apmail-incubator-drill-dev@incubator.apache.org Received: (qmail 15229 invoked by uid 99); 11 May 2015 07:14:03 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 May 2015 07:14:03 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 042631CBF50; Mon, 11 May 2015 07:13:54 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7608709201744101640==" MIME-Version: 1.0 Subject: Re: Review Request 34024: DRILL-3010: Convert bad command error messages into UserExceptions in SqlHandlers From: "Mehant Baid" To: "Mehant Baid" Cc: "Venki Korukanti" , "drill" Date: Mon, 11 May 2015 07:13:54 -0000 Message-ID: <20150511071354.12558.76477@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Mehant Baid" X-ReviewGroup: drill-git X-ReviewRequest-URL: https://reviews.apache.org/r/34024/ X-Sender: "Mehant Baid" References: <20150510162348.12558.39826@reviews.apache.org> In-Reply-To: <20150510162348.12558.39826@reviews.apache.org> Reply-To: "Mehant Baid" X-ReviewRequest-Repository: drill-git --===============7608709201744101640== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34024/#review83207 ----------------------------------------------------------- Ship it! Ship It! - Mehant Baid On May 10, 2015, 4:23 p.m., Venki Korukanti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34024/ > ----------------------------------------------------------- > > (Updated May 10, 2015, 4:23 p.m.) > > > Review request for drill and Mehant Baid. > > > Bugs: DRILL-3010 > https://issues.apache.org/jira/browse/DRILL-3010 > > > Repository: drill-git > > > Description > ------- > > Please see for details: https://issues.apache.org/jira/browse/DRILL-3010 > > > Diffs > ----- > > common/src/main/java/org/apache/drill/common/exceptions/UserException.java 9283339 > exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java 9e2f210 > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SchemaUtilites.java PRE-CREATION > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/AbstractSqlHandler.java 96fd877 > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/CreateTableHandler.java e9ac1e1 > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DescribeTableHandler.java c76914b > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ShowFileHandler.java 7062375 > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ShowTablesHandler.java 3d42f76 > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/SqlHandlerUtil.java 7ae5e0d > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/UseSchemaHandler.java e17e275 > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ViewHandler.java c59c3a2 > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserSession.java 9f1a695 > exec/java-exec/src/main/java/org/apache/drill/exec/store/AbstractSchema.java 33ddea5 > exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceSchemaFactory.java 916564d > exec/java-exec/src/test/java/org/apache/drill/BaseTestQuery.java f8ec090 > exec/java-exec/src/test/java/org/apache/drill/exec/impersonation/TestImpersonationMetadata.java 411660f > exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java 958cf1a > exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestCTAS.java 5fff956 > exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestInfoSchema.java 8bcbc7a > exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestViewSupport.java 0fc1f32 > protocol/src/main/java/org/apache/drill/exec/proto/UserBitShared.java a229450 > protocol/src/main/java/org/apache/drill/exec/proto/beans/DrillPBError.java 873ffa4 > protocol/src/main/protobuf/UserBitShared.proto a17dbc7 > > Diff: https://reviews.apache.org/r/34024/diff/ > > > Testing > ------- > > Existing unittest have good coverage of various exepected bad command message. Converted those to test for UserException with expected error message. > > > Thanks, > > Venki Korukanti > > --===============7608709201744101640==--