Return-Path: X-Original-To: apmail-drill-dev-archive@www.apache.org Delivered-To: apmail-drill-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9611618988 for ; Sat, 9 May 2015 01:14:56 +0000 (UTC) Received: (qmail 96653 invoked by uid 500); 9 May 2015 01:14:56 -0000 Delivered-To: apmail-drill-dev-archive@drill.apache.org Received: (qmail 96598 invoked by uid 500); 9 May 2015 01:14:56 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 96587 invoked by uid 500); 9 May 2015 01:14:56 -0000 Delivered-To: apmail-incubator-drill-dev@incubator.apache.org Received: (qmail 96582 invoked by uid 99); 9 May 2015 01:14:56 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 09 May 2015 01:14:56 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 253491DD298; Sat, 9 May 2015 01:14:57 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7528563077880617113==" MIME-Version: 1.0 Subject: Review Request 34008: DRILL:2977: In WorkManager, startFragmentPendingRemote() and addFragmentRunner() need to be permuted From: "Sudheesh Katkam" To: "Jacques Nadeau" Cc: "Sudheesh Katkam" , "drill" Date: Sat, 09 May 2015 01:14:57 -0000 Message-ID: <20150509011457.31936.90219@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Sudheesh Katkam" X-ReviewGroup: drill-git X-ReviewRequest-URL: https://reviews.apache.org/r/34008/ X-Sender: "Sudheesh Katkam" Reply-To: "Sudheesh Katkam" X-ReviewRequest-Repository: drill-git --===============7528563077880617113== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34008/ ----------------------------------------------------------- Review request for drill and Jacques Nadeau. Repository: drill-git Description ------- **INITIAL PATCH** The current implementation waits for the first batch to start a pending remote fragment. This wait is unnecessary given the fast schema behavior; start the fragment as soon as it receives the plan fragment from the Foreman. In this case startFragmentPendingRemote() and addFragmentRunner() are redundant in WorkManager. Diffs ----- exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataResponseHandlerImpl.java e18b94c exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java a3ceb8f exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/ControlHandlerImpl.java b6c6852 exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java 49d0c94 exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/QueryManager.java 34fa639 exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/RootFragmentManager.java b1c3fe0 Diff: https://reviews.apache.org/r/34008/diff/ Testing ------- Thanks, Sudheesh Katkam --===============7528563077880617113==--