Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
Content-Type: multipart/alternative;
 boundary="===============6767804258929762442=="
MIME-Version: 1.0
Subject: Re: Review Request 30327: Drill-1545 v2 allowing custom extensions on
 json files
From: "Jason Altekruse" <altekrusejason@gmail.com>
To: "Jason Altekruse" <altekrusejason@gmail.com>,
 "drill" <drill-dev@incubator.apache.org>
Date: Thu, 07 May 2015 17:18:21 -0000
Message-ID: <20150507171821.1563.13046@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Jason Altekruse" <noreply@reviews.apache.org>
References: <20150127215607.25680.18216@reviews.apache.org>
In-Reply-To: <20150127215607.25680.18216@reviews.apache.org>
Reply-To: "Jason Altekruse" <altekrusejason@gmail.com>

--===============6767804258929762442==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30327/#review82841
-----------------------------------------------------------

Ship it!


While I created this review, it was for the patch created by Hakim and Paul. I am not reviewing my own work, I anticipated having to do a little more work on this and posting a new patch, but hte change required is just an annotation and some manual testing.

- Jason Altekruse


On Jan. 27, 2015, 9:56 p.m., Jason Altekruse wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30327/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2015, 9:56 p.m.)
> 
> 
> Review request for drill.
> 
> 
> Bugs: DRILL-1545
>     https://issues.apache.org/jira/browse/DRILL-1545
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> Patch add support for custom extensions on json files. There was a previous review request for this issue, but there were some problems while testing the patch in a shared cluster environment and with compressed json files. I was not the owner of the previous review request so I could not upload this there.
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/BasicFormatMatcher.java 2ba2910 
>   exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JSONFormatPlugin.java d41243d 
>   exec/java-exec/src/main/resources/bootstrap-storage-plugins.json 6bf1872 
> 
> Diff: https://reviews.apache.org/r/30327/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jason Altekruse
> 
>


--===============6767804258929762442==--