Return-Path: X-Original-To: apmail-drill-dev-archive@www.apache.org Delivered-To: apmail-drill-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2327A173BE for ; Tue, 5 May 2015 01:11:08 +0000 (UTC) Received: (qmail 4169 invoked by uid 500); 5 May 2015 01:11:07 -0000 Delivered-To: apmail-drill-dev-archive@drill.apache.org Received: (qmail 4113 invoked by uid 500); 5 May 2015 01:11:07 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 4102 invoked by uid 500); 5 May 2015 01:11:07 -0000 Delivered-To: apmail-incubator-drill-dev@incubator.apache.org Received: (qmail 4096 invoked by uid 99); 5 May 2015 01:11:07 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 May 2015 01:11:07 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id BF8DF1DBE2B; Tue, 5 May 2015 01:11:06 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8018566159527363605==" MIME-Version: 1.0 Subject: Review Request 33833: DRILL-2848: Part 2: Provide option to disable decimal type From: "Mehant Baid" To: "Jason Altekruse" , "Jinfeng Ni" Cc: "Mehant Baid" , "drill" Date: Tue, 05 May 2015 01:11:06 -0000 Message-ID: <20150505011106.8788.71373@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Mehant Baid" X-ReviewGroup: drill-git X-ReviewRequest-URL: https://reviews.apache.org/r/33833/ X-Sender: "Mehant Baid" Reply-To: "Mehant Baid" X-ReviewRequest-Repository: drill-git --===============8018566159527363605== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33833/ ----------------------------------------------------------- Review request for drill, Jason Altekruse and Jinfeng Ni. Repository: drill-git Description ------- This patch adds an option to enable/ disable decimal data type. Disabled casting to decimal, reading decimal from parquet and hive. Diffs ----- contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBasePushFilterIntoScan.java f1f3a0b contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveRecordReader.java 8c400ea contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/MongoPushDownFilterForScan.java 4fd80bd exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillConstExecutor.java 92e5678 exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillOptiq.java 441f2e3 exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillParseContext.java be4474f exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/PruneScanRule.java c8be019 exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/FilterPrel.java b631cdc exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/FlattenPrel.java e206951 exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/PlannerSettings.java 8f089c4 exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/ProjectAllowDupPrel.java cc215f8 exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/ProjectPrel.java 35fa5be exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlWorker.java c918723 exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ExplainHandler.java 1636a25 exec/java-exec/src/main/java/org/apache/drill/exec/server/options/SystemOptionManager.java 33b2a4c exec/java-exec/src/main/java/org/apache/drill/exec/store/ischema/InfoSchemaPushFilterIntoRecordGenerator.java 0cf12b4 exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetReaderUtility.java PRE-CREATION exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetRecordReader.java 11d0042 exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetToDrillTypeConverter.java 7c3eeb8 exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet2/DrillParquetGroupConverter.java 389c1f6 exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet2/DrillParquetReader.java 921d134 exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet2/DrillParquetRecordMaterializer.java 574df40 exec/java-exec/src/main/java/org/apache/drill/exec/work/ExecErrorConstants.java PRE-CREATION exec/java-exec/src/test/java/org/apache/drill/TestBugFixes.java c627ff2 exec/java-exec/src/test/java/org/apache/drill/TestDisabledFunctionality.java 504524d exec/java-exec/src/test/java/org/apache/drill/TestFrameworkTest.java 3abd193 exec/java-exec/src/test/java/org/apache/drill/TestFunctionsQuery.java 67131c1 exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestCastEmptyStrings.java 3e05c0e exec/java-exec/src/test/java/org/apache/drill/exec/fn/interp/TestConstantFolding.java 2c23df4 exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java 5670e1e exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestWriter.java 5991046 exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/columnreaders/TestColumnReaderFactory.java 9ae6b78 exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet2/TestDrillParquetReader.java 782191f exec/jdbc/src/test/java/org/apache/drill/jdbc/test/JdbcTestQueryBase.java 5c0a0e5 exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestAggregateFunctionsQuery.java aa68e9f Diff: https://reviews.apache.org/r/33833/diff/ Testing ------- Added negative tests. Modified existing unit tests to use the newly added parameter. Thanks, Mehant Baid --===============8018566159527363605==--