Return-Path: X-Original-To: apmail-drill-dev-archive@www.apache.org Delivered-To: apmail-drill-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 893A41801F for ; Mon, 4 May 2015 19:08:26 +0000 (UTC) Received: (qmail 53287 invoked by uid 500); 4 May 2015 19:08:26 -0000 Delivered-To: apmail-drill-dev-archive@drill.apache.org Received: (qmail 53236 invoked by uid 500); 4 May 2015 19:08:26 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 53225 invoked by uid 500); 4 May 2015 19:08:26 -0000 Delivered-To: apmail-incubator-drill-dev@incubator.apache.org Received: (qmail 53218 invoked by uid 99); 4 May 2015 19:08:26 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 May 2015 19:08:26 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 5C9011DBDF9; Mon, 4 May 2015 19:08:25 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2893765564701904054==" MIME-Version: 1.0 Subject: Re: Review Request 33779: DRILL-2932: Fix: Error printed to System.out; text not in exception message. From: "Parth Chandra" To: "Mehant Baid" , "abdelhakim deneche" , "Parth Chandra" Cc: "Daniel Barclay" , "drill" Date: Mon, 04 May 2015 19:08:25 -0000 Message-ID: <20150504190825.20176.88425@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Parth Chandra" X-ReviewGroup: drill-git X-ReviewRequest-URL: https://reviews.apache.org/r/33779/ X-Sender: "Parth Chandra" References: <20150502061205.1509.17321@reviews.apache.org> In-Reply-To: <20150502061205.1509.17321@reviews.apache.org> Reply-To: "Parth Chandra" X-ReviewRequest-Repository: drill-git --===============2893765564701904054== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33779/#review82418 ----------------------------------------------------------- exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillCursor.java This is never released if an exception is throw. - Parth Chandra On May 2, 2015, 6:12 a.m., Daniel Barclay wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33779/ > ----------------------------------------------------------- > > (Updated May 2, 2015, 6:12 a.m.) > > > Review request for drill, abdelhakim deneche, Mehant Baid, and Parth Chandra. > > > Bugs: DRILL-2932 > https://issues.apache.org/jira/browse/DRILL-2932 > > > Repository: drill-git > > > Description > ------- > > Main: > - Removed the System.out.println(...) from submissionFailed(...). > - Created unit test for execute...(...) exceptions. > - Put UserException's message text in SQLException's message (didn't just wrap). > - Added undoing of extra wrapping by AvaticaStatement.execute...(...). > - Refined related exception handling (handled cases separately, narrowed throws declarations and catches). > > JDBC cleanup: > - Renamed ex -> executionFailureException > - Added getNext() method doc. comment. > - Removed some obsolete alignment spaces. > > Added DRILL-2933 (SchemaChangeException) "review this" TODOs. > - DrillCursor; > - MergingRecordBatch, ParquetResultListener, PrintingResultsListener, QueryWrapper, RecordBatchLoader, UnorderedReceiverBatch; > - TestDrillbitResilience, TestTextColumn, BaseTestQuery, DrillTestWrapper; > > > Diffs > ----- > > exec/java-exec/src/main/java/org/apache/drill/exec/client/PrintingResultsListener.java 64e7266 > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/mergereceiver/MergingRecordBatch.java 40cbc89 > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java 094865e > exec/java-exec/src/main/java/org/apache/drill/exec/record/RecordBatchLoader.java 088630c > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/QueryResultHandler.java 3beae89 > exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/QueryWrapper.java aa43aa9 > exec/java-exec/src/test/java/org/apache/drill/BaseTestQuery.java b02051b > exec/java-exec/src/test/java/org/apache/drill/DrillTestWrapper.java d05c896 > exec/java-exec/src/test/java/org/apache/drill/exec/server/TestDrillbitResilience.java 2698701 > exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/ParquetResultListener.java 0e80f91 > exec/java-exec/src/test/java/org/apache/drill/exec/store/text/TestTextColumn.java 3c1a38a > exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillCursor.java 41b89ce > exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillStatement.java ba265e6 > exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java 484a5e5 > exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestExecutionExceptionsToClient.java PRE-CREATION > > Diff: https://reviews.apache.org/r/33779/diff/ > > > Testing > ------- > > Ran SQLLine to confirm change from System.out plus poor SQLException to good SQLException. > > Ran new specific unit test. > > Ran regular tests; no new failures. > > > Thanks, > > Daniel Barclay > > --===============2893765564701904054==--