Return-Path: X-Original-To: apmail-drill-dev-archive@www.apache.org Delivered-To: apmail-drill-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 741A517F90 for ; Sat, 2 May 2015 00:03:21 +0000 (UTC) Received: (qmail 66559 invoked by uid 500); 2 May 2015 00:03:21 -0000 Delivered-To: apmail-drill-dev-archive@drill.apache.org Received: (qmail 66498 invoked by uid 500); 2 May 2015 00:03:21 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 66487 invoked by uid 500); 2 May 2015 00:03:20 -0000 Delivered-To: apmail-incubator-drill-dev@incubator.apache.org Received: (qmail 66480 invoked by uid 99); 2 May 2015 00:03:20 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 02 May 2015 00:03:20 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 9A67C1DBD25; Sat, 2 May 2015 00:03:20 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============9114224641497862523==" MIME-Version: 1.0 Subject: Re: Review Request 33599: DRILL-2885: Return more precise error codes on handshake failures in C++ client From: "Parth Chandra" To: "Xiao Meng" , "Alexander zarei" , "Parth Chandra" Cc: "Norris Lee" , "drill" Date: Sat, 02 May 2015 00:03:20 -0000 Message-ID: <20150502000320.1509.41533@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Parth Chandra" X-ReviewGroup: drill-git X-ReviewRequest-URL: https://reviews.apache.org/r/33599/ X-Sender: "Parth Chandra" References: <20150501232148.1508.15387@reviews.apache.org> In-Reply-To: <20150501232148.1508.15387@reviews.apache.org> Reply-To: "Parth Chandra" X-ReviewRequest-Repository: drill-git --===============9114224641497862523== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33599/#review82296 ----------------------------------------------------------- Ship it! Ship It! - Parth Chandra On May 1, 2015, 11:21 p.m., Norris Lee wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33599/ > ----------------------------------------------------------- > > (Updated May 1, 2015, 11:21 p.m.) > > > Review request for drill, Alexander zarei, Parth Chandra, and Xiao Meng. > > > Bugs: DRILL-2885 > https://issues.apache.org/jira/browse/DRILL-2885 > > > Repository: drill-git > > > Description > ------- > > Currently, when a handshake failure occurs, only a generic handshake error code is returned. Should be more granular for better error messages (Otherwise will have to resort to dumping whatever error message the server and client returns). > > > Diffs > ----- > > contrib/native/client/src/clientlib/drillClientImpl.cpp a253829 > contrib/native/client/src/include/drill/common.hpp 6662754 > > Diff: https://reviews.apache.org/r/33599/diff/ > > > Testing > ------- > > > Thanks, > > Norris Lee > > --===============9114224641497862523==--