drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jason Altekruse <altekruseja...@gmail.com>
Subject Re: "Banned Dependency" validation error - on master branch; strange Jetty Holder reference
Date Sun, 10 May 2015 22:26:59 GMT
My e-mail client hadn't pulled the rest of the thread when I was writing
that, please message back if you are still having issues after building
from the root and I'll take another look at this.

On Sun, May 10, 2015 at 3:22 PM, Jason Altekruse <altekrusejason@gmail.com>
wrote:

> I had made this change to resolve an issue with static assets like js and
> css not loading on the web ui. We were previously trying to ban this jar,
> but it was specified incorrectly in the maven enforcer plugin, and not
> actually working. I had run a full build before deploying it to a cluster
> to confirm it worked on all of the nodes. I had a timeout test failure on
> the tests I had run last night, so I ended up not merging it right away.
> Jacques picked it up and merged it with a few outstanding patches, so he
> must have had a clean run as well.
>
> I will be looking into this, if you can share the output of `mvn
> dependency:tree` it may help me debug it, I can't think why it would have
> resolved the dependencies differently between builds, but I'll try to
> reproduce the failure.
>
> On Sun, May 10, 2015 at 1:45 PM, Daniel Barclay <dbarclay@maprtech.com>
> wrote:
>
>> After just rebasing on master today, I started getting this validation
>> error:
>>
>> ...
>> [INFO] --- maven-enforcer-plugin:1.3.1:enforce (avoid_bad_dependencies) @
>> drill-jdbc ---
>> [WARNING] Rule 0: org.apache.maven.plugins.enforcer.BannedDependencies
>> failed with message:
>> Found Banned Dependency: org.mortbay.jetty:servlet-api:jar:2.5-20081211
>> Use 'mvn dependency:tree' to locate the source of the banned dependencies.
>> [INFO]
>> ------------------------------------------------------------------------
>> [INFO] BUILD FAILURE
>> ...
>>
>> (The output of" mvn dependency:tree" didn't contain
>> "org.mortbay.jetty:servlet-api".)
>>
>>
>>
>> That was from executing the command:
>>
>>   mvn clean ; (cd exec/jdbc ; mvn validate)
>>
>> (It doesn't happen with a root-level mvn validate.)
>>
>>
>> Even when I switch to my locally unmodified copy of master, I get that
>> message.
>>
>>
>>
>> NOTE:  The template
>> exec/java-exec/src/main/codegen/templates/RepeatedValueVectors.java
>> includes this reference to a Jetty servlet class/interface:
>>
>>   import org.mortbay.jetty.servlet.Holder;
>>
>> Is that intentional?
>>
>> Daniel
>> --
>> Daniel Barclay
>> MapR Technologies
>>
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message