drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jacques Nadeau <jacq...@apache.org>
Subject Re: "Banned Dependency" validation error - on master branch; strange Jetty Holder reference
Date Sun, 10 May 2015 22:14:44 GMT
It is wrong but it doesn't impact anything.  Note that there is a block of
imports followed by:

<@pp.dropOutputFile />

Those items are actually thrown away and never used anywhere. The only
thing that should be above drop in this file should be the license.
Everything else is meaningless.  (Note that this different from other files
where we may have template directives above the drop.




On Sun, May 10, 2015 at 2:58 PM, Daniel Barclay <dbarclay@maprtech.com>
wrote:

> Did you do a mvn clean install at the root level before you ran this
>>
> command?
>
> No.  I had done just a "mvn clean".
>
> What about the reference to:
>
>   import org.mortbay.jetty.servlet.Holder;
>
> in
>
> exec/java-exec/src/main/codegen/templates/RepeatedValueVectors.java
>
> Is that correct?
>
> Daniel
>
>
>
>
>
> Jacques Nadeau wrote:
>
>> The enforcer plugin should be make sure that banned dependencies are not
>> included.  This is on purpose and should not be changed.
>>
>> Because of the nature of our dependencies, you have to do a mvn install at
>> the root before you can assume a sub module level action will work.
>> Otherwise, sub module behaviors may source from an old version stored in
>> your .m2 repo.
>>
>> Did you do a mvn clean install at the root level before you ran this
>> command?
>>
>> I don't think there is any mistake based on what you've described above.
>> It sounds like you pulled down the latest code then tried to do a partial
>> build.  There was a patch that went in this morning related to DRILL-2841
>> to make sure this dependency is never include in Drill as it breaks the
>> web
>> ui.
>>
>>
>> On Sun, May 10, 2015 at 1:45 PM, Daniel Barclay <dbarclay@maprtech.com>
>> wrote:
>>
>>  After just rebasing on master today, I started getting this validation
>>> error:
>>>
>>> ...
>>> [INFO] --- maven-enforcer-plugin:1.3.1:enforce (avoid_bad_dependencies) @
>>> drill-jdbc ---
>>> [WARNING] Rule 0: org.apache.maven.plugins.enforcer.BannedDependencies
>>> failed with message:
>>> Found Banned Dependency: org.mortbay.jetty:servlet-api:jar:2.5-20081211
>>> Use 'mvn dependency:tree' to locate the source of the banned
>>> dependencies.
>>> [INFO]
>>> ------------------------------------------------------------------------
>>> [INFO] BUILD FAILURE
>>> ...
>>>
>>> (The output of" mvn dependency:tree" didn't contain
>>> "org.mortbay.jetty:servlet-api".)
>>>
>>>
>>>
>>> That was from executing the command:
>>>
>>>    mvn clean ; (cd exec/jdbc ; mvn validate)
>>>
>>> (It doesn't happen with a root-level mvn validate.)
>>>
>>>
>>> Even when I switch to my locally unmodified copy of master, I get that
>>> message.
>>>
>>>
>>>
>>> NOTE:  The template
>>> exec/java-exec/src/main/codegen/templates/RepeatedValueVectors.java
>>> includes this reference to a Jetty servlet class/interface:
>>>
>>>    import org.mortbay.jetty.servlet.Holder;
>>>
>>> Is that intentional?
>>>
>>> Daniel
>>> --
>>> Daniel Barclay
>>> MapR Technologies
>>>
>>>
>
> --
> Daniel Barclay
> MapR Technologies
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message