drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sudheesh Katkam" <skat...@maprtech.com>
Subject Re: Review Request 34690: DRILL-2903 Update TestDrillbitResilience tests so that they correctly manage canceled queries that get to complete too quickly
Date Fri, 29 May 2015 23:52:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34690/
-----------------------------------------------------------

(Updated May 29, 2015, 11:52 p.m.)


Review request for drill, abdelhakim deneche, Chris Westin, and Venki Korukanti.


Changes
-------

Addressing review comments + two other small nits


Bugs: DRILL-2903
    https://issues.apache.org/jira/browse/DRILL-2903


Repository: drill-git


Description
-------

DRILL-2903: General improvements to tests in TestDrillbitResilience
+ Added RepeatTestRule to tests that are flaky
+ Added Controls.Builder to create controls string in tests
+ Added @Ignore to failing tests (filed JIRAs)

Other fixes:
+ Added @Override to ScanBatch#close to avoid potential bugs
+ Added docs link in ProtobufLengthDecoder
+ Fixed logging issue in CountDownLatchImpl


Diffs (updated)
-----

  common/src/main/java/org/apache/drill/common/util/RepeatTestRule.java PRE-CREATION 
  common/src/main/java/org/apache/drill/common/util/TestTools.java 5be8d40 
  common/src/test/java/org/apache/drill/test/DrillTest.java bbe014f 
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java 6176f77

  exec/java-exec/src/main/java/org/apache/drill/exec/rpc/ProtobufLengthDecoder.java 4f075d3

  exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/ControlTunnel.java 16b9b63

  exec/java-exec/src/main/java/org/apache/drill/exec/testing/CountDownLatchInjectionImpl.java
561d816 
  exec/java-exec/src/main/java/org/apache/drill/exec/testing/ExecutionControls.java 639802f

  exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/ControlMessageHandler.java
8ee7d38 
  exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java 5d07b49 
  exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/QueryManager.java 71b77c6

  exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java e5e0700

  exec/java-exec/src/test/java/org/apache/drill/exec/server/TestDrillbitResilience.java 696aed8

  exec/java-exec/src/test/java/org/apache/drill/exec/testing/Controls.java PRE-CREATION 
  exec/java-exec/src/test/java/org/apache/drill/exec/testing/ControlsInjectionUtil.java 346c6dd

  exec/java-exec/src/test/java/org/apache/drill/exec/testing/TestCountDownLatchInjection.java
c98f54c 
  exec/java-exec/src/test/java/org/apache/drill/exec/testing/TestExceptionInjection.java e3558a1

  exec/java-exec/src/test/java/org/apache/drill/exec/testing/TestPauseInjection.java ba29c58


Diff: https://reviews.apache.org/r/34690/diff/


Testing
-------

Unit tests pass on Linux, and successful regression tests.


Thanks,

Sudheesh Katkam


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message