drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Westin" <chriswesti...@gmail.com>
Subject Re: Review Request 34690: DRILL-2903 Update TestDrillbitResilience tests so that they correctly manage canceled queries that get to complete too quickly
Date Fri, 29 May 2015 21:26:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34690/#review85816
-----------------------------------------------------------


A couple of minor nits, but otherwise SHIP IT (non-binding).


exec/java-exec/src/test/java/org/apache/drill/exec/testing/Controls.java
<https://reviews.apache.org/r/34690/#comment137638>

    This might be a bit misleading; it's not partial, it's the same builder.
    
    I'd just say "this builder" to indicate that this object is meant to be used in a "fluent
style" (that's how this kind of builder object is often described). As it is now, it could
imply the builders are also immutable, and that it returns a new copy with the added exception
injection.



exec/java-exec/src/test/java/org/apache/drill/exec/testing/Controls.java
<https://reviews.apache.org/r/34690/#comment137636>

    I'll bet it's cheaper to use
    
    builder.setLength(builder.length() - 1)
    
    because it won't be set up with the expectation that there are following characters to
copy back one space.


- Chris Westin


On May 29, 2015, 10:48 a.m., Sudheesh Katkam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34690/
> -----------------------------------------------------------
> 
> (Updated May 29, 2015, 10:48 a.m.)
> 
> 
> Review request for drill, abdelhakim deneche, Chris Westin, and Venki Korukanti.
> 
> 
> Bugs: DRILL-2903
>     https://issues.apache.org/jira/browse/DRILL-2903
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> DRILL-2903: General improvements to tests in TestDrillbitResilience
> + Added RepeatTestRule to tests that are flaky
> + Added Controls.Builder to create controls string in tests
> + Added @Ignore to failing tests (filed JIRAs)
> 
> Other fixes:
> + Added @Override to ScanBatch#close to avoid potential bugs
> + Added docs link in ProtobufLengthDecoder
> + Fixed logging issue in CountDownLatchImpl
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/drill/common/util/RepeatTestRule.java PRE-CREATION

>   common/src/main/java/org/apache/drill/common/util/TestTools.java 5be8d40 
>   common/src/test/java/org/apache/drill/test/DrillTest.java bbe014f 
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java 6176f77

>   exec/java-exec/src/main/java/org/apache/drill/exec/rpc/ProtobufLengthDecoder.java 4f075d3

>   exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/ControlTunnel.java 16b9b63

>   exec/java-exec/src/main/java/org/apache/drill/exec/testing/CountDownLatchInjectionImpl.java
561d816 
>   exec/java-exec/src/main/java/org/apache/drill/exec/testing/ExecutionControls.java 639802f

>   exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/ControlMessageHandler.java
8ee7d38 
>   exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java 5d07b49

>   exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/QueryManager.java 71b77c6

>   exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java
e5e0700 
>   exec/java-exec/src/test/java/org/apache/drill/exec/server/TestDrillbitResilience.java
696aed8 
>   exec/java-exec/src/test/java/org/apache/drill/exec/testing/Controls.java PRE-CREATION

>   exec/java-exec/src/test/java/org/apache/drill/exec/testing/ControlsInjectionUtil.java
346c6dd 
>   exec/java-exec/src/test/java/org/apache/drill/exec/testing/TestCountDownLatchInjection.java
c98f54c 
>   exec/java-exec/src/test/java/org/apache/drill/exec/testing/TestExceptionInjection.java
e3558a1 
>   exec/java-exec/src/test/java/org/apache/drill/exec/testing/TestPauseInjection.java
ba29c58 
> 
> Diff: https://reviews.apache.org/r/34690/diff/
> 
> 
> Testing
> -------
> 
> Unit tests pass on Linux, and successful regression tests.
> 
> 
> Thanks,
> 
> Sudheesh Katkam
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message