drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aman Sinha" <asi...@maprtech.com>
Subject Re: Review Request 34528: DRILL-2746, DRILL-3130: Add a new DrillRule DrillUnionRule
Date Fri, 29 May 2015 14:47:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34528/#review85724
-----------------------------------------------------------



exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java
<https://reviews.apache.org/r/34528/#comment137467>

    For the plan validation for filter push-down it is not sufficient to check for exclusions.
 Could you check for the filter presence on both side of the Union ? Otherwise we won't know
if the filter somehow got dropped.


- Aman Sinha


On May 28, 2015, 5:17 p.m., Sean Hsuan-Yi Chu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34528/
> -----------------------------------------------------------
> 
> (Updated May 28, 2015, 5:17 p.m.)
> 
> 
> Review request for drill, Aman Sinha and Jinfeng Ni.
> 
> 
> Bugs: DRILL-2746
>     https://issues.apache.org/jira/browse/DRILL-2746
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> Add two DrillRules to push Project and Filter below set operators
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillProjectSetOpTransposeRule.java
PRE-CREATION 
>   exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillRuleSets.java
f7cfbf4 
>   exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java 5f98d90 
>   exec/java-exec/src/test/resources/testframework/testUnionAllQueries/testProjectDownOverUnionAllImplicitCasting.tsv
PRE-CREATION 
>   exec/java-exec/src/test/resources/testframework/testUnionAllQueries/testProjectFiltertPushDownOverUnionAll.tsv
PRE-CREATION 
>   exec/java-exec/src/test/resources/testframework/testUnionAllQueries/testProjectPushDownOverUnionAllWithProject.tsv
PRE-CREATION 
>   exec/java-exec/src/test/resources/testframework/testUnionAllQueries/testProjectPushDownOverUnionAllWithoutProject.tsv
PRE-CREATION 
>   exec/java-exec/src/test/resources/testframework/testUnionAllQueries/testProjectPushDownProjectColumnReorderingAndAlias.tsv
PRE-CREATION 
>   exec/java-exec/src/test/resources/testframework/testUnionAllQueries/testProjectWithExpressionPushDownOverUnionAll.tsv
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/34528/diff/
> 
> 
> Testing
> -------
> 
> Unit test, tpch, fucntional
> 
> 
> Thanks,
> 
> Sean Hsuan-Yi Chu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message