drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matt Burgess" <mattyb...@gmail.com>
Subject Review Request 34749: DRILL-3199: GenericAccessor doesn't support isNull
Date Thu, 28 May 2015 23:12:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34749/
-----------------------------------------------------------

Review request for drill.


Repository: drill-git


Description
-------

When calling isNull() from a result set, if the method gets delegated/propagated to a GenericAccessor,
it throws an UnsupportedOperationException. Since GenericAccessor uses its underlying ValueVector
for most other methods, I think it should also delegate the isNull() method and return whatever
comes back from the ValueVector.isNull() call.


Diffs
-----

  exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/GenericAccessor.java
347cf26 
  exec/java-exec/src/test/java/org/apache/drill/exec/vector/accessor/GenericAccessorTest.java
PRE-CREATION 

Diff: https://reviews.apache.org/r/34749/diff/


Testing
-------

Patch provides implementation of the isNull() method, along with unit tests covering 100%
of the GenericAccessor class


Thanks,

Matt Burgess


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message