drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Hsuan-Yi Chu" <hsua...@usc.edu>
Subject Re: Review Request 34528: DRILL-2746, DRILL-3130: Add a new DrillRule DrillUnionRule
Date Thu, 28 May 2015 17:17:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34528/
-----------------------------------------------------------

(Updated May 28, 2015, 5:17 p.m.)


Review request for drill, Aman Sinha and Jinfeng Ni.


Changes
-------

new patch


Bugs: DRILL-2746
    https://issues.apache.org/jira/browse/DRILL-2746


Repository: drill-git


Description
-------

Add two DrillRules to push Project and Filter below set operators


Diffs (updated)
-----

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillProjectSetOpTransposeRule.java
PRE-CREATION 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillRuleSets.java f7cfbf4

  exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java 5f98d90 
  exec/java-exec/src/test/resources/testframework/testUnionAllQueries/testProjectDownOverUnionAllImplicitCasting.tsv
PRE-CREATION 
  exec/java-exec/src/test/resources/testframework/testUnionAllQueries/testProjectFiltertPushDownOverUnionAll.tsv
PRE-CREATION 
  exec/java-exec/src/test/resources/testframework/testUnionAllQueries/testProjectPushDownOverUnionAllWithProject.tsv
PRE-CREATION 
  exec/java-exec/src/test/resources/testframework/testUnionAllQueries/testProjectPushDownOverUnionAllWithoutProject.tsv
PRE-CREATION 
  exec/java-exec/src/test/resources/testframework/testUnionAllQueries/testProjectPushDownProjectColumnReorderingAndAlias.tsv
PRE-CREATION 
  exec/java-exec/src/test/resources/testframework/testUnionAllQueries/testProjectWithExpressionPushDownOverUnionAll.tsv
PRE-CREATION 

Diff: https://reviews.apache.org/r/34528/diff/


Testing
-------

Unit test, tpch, fucntional


Thanks,

Sean Hsuan-Yi Chu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message