drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "abdelhakim deneche" <adene...@gmail.com>
Subject Re: Review Request 34541: DRILL-3147: tpcds-sf1-parquet query 73 causes memory leak
Date Fri, 22 May 2015 23:15:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34541/
-----------------------------------------------------------

(Updated May 22, 2015, 11:15 p.m.)


Review request for drill, Chris Westin and Jacques Nadeau.


Changes
-------

adressed review comments


Bugs: DRILL-3147
    https://issues.apache.org/jira/browse/DRILL-3147


Repository: drill-git


Description
-------

- BaseRawBatchBuffer methods enqueue() and kill() are now synchronized
- TestTpcdsSf1Leak test reproduces the leak, it's ignored by default because it requires a
large dataset


Diffs (updated)
-----

  exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataServer.java 80d2d6e 
  exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/BaseRawBatchBuffer.java 11b6cc8

  exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/RootFragmentManager.java
b770a33 
  exec/java-exec/src/test/java/org/apache/drill/BaseTestQuery.java a07f621 
  exec/java-exec/src/test/java/org/apache/drill/exec/server/TestTpcdsSf1Leaks.java PRE-CREATION

  exec/java-exec/src/test/resources/tpcds-sf1/q73.sql PRE-CREATION 

Diff: https://reviews.apache.org/r/34541/diff/


Testing
-------

still need to run the tests!


Thanks,

abdelhakim deneche


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message