drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Parth Chandra" <pchan...@maprtech.com>
Subject Re: Review Request 34497: DRILL-3108: Replace templated returns with covariant return overrides
Date Fri, 22 May 2015 22:25:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34497/#review85008
-----------------------------------------------------------

Ship it!


Ship It!

- Parth Chandra


On May 20, 2015, 9:04 p.m., Hanifi Gunes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34497/
> -----------------------------------------------------------
> 
> (Updated May 20, 2015, 9:04 p.m.)
> 
> 
> Review request for drill and Parth Chandra.
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> DRILL-3108: Replace templated returns with covariant return overrides
> - Removed template declarations from VV
> - Deleted unused SerializableVector
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/vector/BaseDataValueVector.java
6d356f2c24947d435dcbe2ce2bc776727f6c8e26 
>   exec/java-exec/src/main/java/org/apache/drill/exec/vector/BaseRepeatedValueVector.java
bcf0793751443ffed5879d36e09dc97ac4f2591f 
>   exec/java-exec/src/main/java/org/apache/drill/exec/vector/BaseValueVector.java 67c489daf0a172d4fe0f8df1abb07a0454091299

>   exec/java-exec/src/main/java/org/apache/drill/exec/vector/RepeatedValueVector.java
d5a82816a3ca4fb1a6ab99244188f9997a7d3a2b 
>   exec/java-exec/src/main/java/org/apache/drill/exec/vector/SerializableVector.java 62c8a18eac9cc5e964ce38fa0441bf84f36f7e93

>   exec/java-exec/src/main/java/org/apache/drill/exec/vector/ValueVector.java ab9992e6fa68c7986ad35c44a8ebb50d656e5915

>   exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedListVector.java
b5de8b1e2081e13c36fe563002dad00341367b6e 
> 
> Diff: https://reviews.apache.org/r/34497/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hanifi Gunes
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message