drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Westin" <chriswesti...@gmail.com>
Subject Re: Review Request 34603: DRILL-3167: When a query fails, Foreman should wait for all fragments to finish cleaning up before sending a FAILED state to the client
Date Fri, 22 May 2015 22:14:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34603/#review85005
-----------------------------------------------------------


Ship it (non-binding).

It figures that we would need something (FAILING) comparable to CANCELLATION_REQUESTED in
order to deal with the different states of having detected a failure and waiting for everything
to shut down, and the actual completion of that, just like we have to do in the case of a
cancellation.


protocol/src/main/protobuf/UserBitShared.proto
<https://reviews.apache.org/r/34603/#comment136484>

    Is this aligned right? It doesn't look right in the diff for some reason.


- Chris Westin


On May 22, 2015, 10:42 a.m., abdelhakim deneche wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34603/
> -----------------------------------------------------------
> 
> (Updated May 22, 2015, 10:42 a.m.)
> 
> 
> Review request for drill, Chris Westin, Jacques Nadeau, and Sudheesh Katkam.
> 
> 
> Bugs: DRILL-3167
>     https://issues.apache.org/jira/browse/DRILL-3167
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> - In case of a failure the Foreman will cancel all fragments and move to a FAILING state
until all fragments are terminated
> - QueryManager.cancelExecutingFragments() returns false if no fragment available
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java 5d07b49

>   exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/QueryManager.java 71b77c6

>   protocol/src/main/java/org/apache/drill/exec/proto/UserBitShared.java 92afa4f 
>   protocol/src/main/java/org/apache/drill/exec/proto/beans/QueryResult.java 474e330 
>   protocol/src/main/protobuf/UserBitShared.proto 68c8612 
> 
> Diff: https://reviews.apache.org/r/34603/diff/
> 
> 
> Testing
> -------
> 
> unit tests are passing
> 
> 
> Thanks,
> 
> abdelhakim deneche
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message