drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hanifi Gunes" <hanifigu...@gmail.com>
Subject Re: Review Request 34499: DRILL-3032: repeated vectors should handle late type && instantiate its children upon construction
Date Fri, 22 May 2015 21:19:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34499/
-----------------------------------------------------------

(Updated May 22, 2015, 9:19 p.m.)


Review request for drill and Mehant Baid.


Changes
-------

- added a test case
- stylistic changes by IDE


Repository: drill-git


Description
-------

DRILL-3032: repeated vectors should handle late type && instantiate its children upon
construction

MaterializedField.java
- remove unused imports

BaseRepeatedValueVector.java
- repeated types should not attempt to create a child vector of late type

RepeatedListVector.java
- pass entire field rather than type to recursively instantiate a list vector

The rest
- minor code refactoring


Diffs (updated)
-----

  exec/java-exec/src/main/java/org/apache/drill/exec/record/MaterializedField.java 64ba8611b36377084d3912f997ea428715ed2cf8

  exec/java-exec/src/main/java/org/apache/drill/exec/record/VectorContainer.java e5f4be1e960462f27f5c9477a3225fb7767cfde0

  exec/java-exec/src/main/java/org/apache/drill/exec/vector/BaseRepeatedValueVector.java bcf0793751443ffed5879d36e09dc97ac4f2591f

  exec/java-exec/src/main/java/org/apache/drill/exec/vector/VectorDescriptor.java 9a29848cf88bcba9e8d9ef57eec08f28a0ba9b4f

  exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedListVector.java
b5de8b1e2081e13c36fe563002dad00341367b6e 
  exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java 75bbc13eb47b3b1dfe95b3a24f2ecfd4b72f845b

  exec/java-exec/src/test/resources/join/join-left-drill-3032.json PRE-CREATION 
  exec/java-exec/src/test/resources/join/join-right-drill-3032.json PRE-CREATION 

Diff: https://reviews.apache.org/r/34499/diff/


Testing
-------

all


Thanks,

Hanifi Gunes


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message