drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sudheesh Katkam" <skat...@maprtech.com>
Subject Re: Review Request 34253: DRILL-3061: Fix memory leaks in TestDrillbitResilience
Date Fri, 15 May 2015 02:33:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34253/#review83887
-----------------------------------------------------------



exec/java-exec/src/test/java/org/apache/drill/exec/server/TestDrillbitResilience.java
<https://reviews.apache.org/r/34253/#comment134967>

    Move "query" to end of parameter list



exec/java-exec/src/test/java/org/apache/drill/exec/server/TestDrillbitResilience.java
<https://reviews.apache.org/r/34253/#comment134966>

    +=


- Sudheesh Katkam


On May 15, 2015, 2:02 a.m., abdelhakim deneche wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34253/
> -----------------------------------------------------------
> 
> (Updated May 15, 2015, 2:02 a.m.)
> 
> 
> Review request for drill, Jacques Nadeau, Sudheesh Katkam, and Venki Korukanti.
> 
> 
> Bugs: DRILL-3061
>     https://issues.apache.org/jira/browse/DRILL-3061
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> although TestDrillbitResilience was improved with memory leak checks, I marked it as
@Ignore because some unit tests are still hanging
> 
> Fixed a race condition in WorkEventBus that causes "Data not accepted downstream" error
messages
> 
> made small change to ZookeeperHelper to help unit test enable RETURN_ERROR_FOR_FAILURE_IN_CANCELLED_FRAGMENTS
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/WorkEventBus.java ddd7828

>   exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataServer.java 0d4077e

>   exec/java-exec/src/test/java/org/apache/drill/exec/ZookeeperHelper.java a5db81d 
>   exec/java-exec/src/test/java/org/apache/drill/exec/server/TestDrillbitResilience.java
f95fbe1 
> 
> Diff: https://reviews.apache.org/r/34253/diff/
> 
> 
> Testing
> -------
> 
> not tested yet!!!
> 
> 
> Thanks,
> 
> abdelhakim deneche
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message