drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "abdelhakim deneche" <adene...@gmail.com>
Subject Re: Review Request 34245: DRILL-3063: TestQueriesOnLargeFile leaks memory with 16M limit
Date Fri, 15 May 2015 00:33:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34245/#review83879
-----------------------------------------------------------



exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java
<https://reviews.apache.org/r/34245/#comment134955>

    if we return here, this fragment will never send it's final state to the Foreman


- abdelhakim deneche


On May 15, 2015, 12:10 a.m., Chris Westin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34245/
> -----------------------------------------------------------
> 
> (Updated May 15, 2015, 12:10 a.m.)
> 
> 
> Review request for drill and Jacques Nadeau.
> 
> 
> Bugs: DRILL-3063
>     https://issues.apache.org/jira/browse/DRILL-3063
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> Changed the cleanup handling at the end of ImplCreator.getExec(), and
> handle the newly returned null value in FragmentExecutor.run().
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ImplCreator.java 77ca0f5

>   exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java
8c49d68 
> 
> Diff: https://reviews.apache.org/r/34245/diff/
> 
> 
> Testing
> -------
> 
> tests are running....
> 
> 
> Thanks,
> 
> Chris Westin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message