drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sudheesh Katkam" <skat...@maprtech.com>
Subject Re: Review Request 34191: DRILL-3052: Canceling a fragment executor before it starts running will cause the Foreman to wait indefinitely for a terminal message from that fragment
Date Thu, 14 May 2015 23:17:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34191/
-----------------------------------------------------------

(Updated May 14, 2015, 11:17 p.m.)


Review request for drill, abdelhakim deneche, Jacques Nadeau, and Venki Korukanti.


Repository: drill-git


Description (updated)
-------

[DRILL-3052](https://issues.apache.org/jira/browse/DRILL-3052), [DRILL-3066](https://issues.apache.org/jira/browse/DRILL-3066),
[DRILL-3072](https://issues.apache.org/jira/browse/DRILL-3072): FragmentExecutor must cleanup
exactly once (root or non-root)

In DRILL-3052 scenario, sendFinalState() is never called
In DRILL-3066 scenario, closeOutResources() is called twice
In DRILL-3072 scenario, root was interrupted by a cancel signal that the root itself sent


Diffs (updated)
-----

  exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java 8c49d68

  exec/java-exec/src/test/java/org/apache/drill/exec/server/TestDrillbitResilience.java f95fbe1


Diff: https://reviews.apache.org/r/34191/diff/


Testing (updated)
-------

Runnning unit and regression tests currently.


Thanks,

Sudheesh Katkam


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message